Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add base64 as a runtime dependency #277

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Add base64 as a runtime dependency #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b26429a
Add base64 as a runtime dependency
orien Feb 19, 2024
d37fa8e
Add conditional development dependency on mutex_m
orien Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,7 @@ end
platforms :jruby do
gem 'jruby-openssl'
end

if RUBY_VERSION >= '3.4'
gem 'mutex_m' # TODO: remove this once as-notifications has such a dependency
end
Comment on lines +28 to +30
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mutex_m is a missing dependency of as-notifications. The dependency should be added to this library.

1 change: 1 addition & 0 deletions webmachine.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ Gem::Specification.new do |gem|
gem.add_runtime_dependency('i18n', ['>= 0.4.0'])
gem.add_runtime_dependency('multi_json')
gem.add_runtime_dependency('as-notifications', ['>= 1.0.2', '< 2.0'])
gem.add_runtime_dependency('base64')

gem.add_development_dependency('webrick', ['~> 1.7.0'])
gem.add_development_dependency('standard', ['~> 1.21'])
Expand Down
Loading