Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base64 as a runtime dependency #277

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Add base64 as a runtime dependency #277

merged 2 commits into from
Feb 19, 2024

Conversation

orien
Copy link
Contributor

@orien orien commented Feb 19, 2024

Context

Webmachine uses the base64 library from the Ruby standard library:

In the forthcoming Ruby 3.4, the base64 library will be come a 'bundled' library. It must be included in gem sets to be used with Bundler.

In Ruby 3.3 a deprecation warning is shown:

lib/webmachine/decision/flow.rb:3: warning: base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec.

Example: https://github.com/webmachine/webmachine-ruby/actions/runs/7955436555/job/21714422307?pr=276#step:5:5

Change

Add base64 as a runtime dependency in the gemspec.

Comment on lines +28 to +30
if RUBY_VERSION >= '3.4'
gem 'mutex_m' # TODO: remove this once as-notifications has such a dependency
end
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mutex_m is a missing dependency of as-notifications. The dependency should be added to this library.

@seancribbs seancribbs merged commit 6e187db into master Feb 19, 2024
12 checks passed
@seancribbs seancribbs deleted the base64 branch February 19, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants