Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Icon purpose doesn't support combination of values #3839

Closed
wants to merge 1 commit into from

Conversation

sarvaje
Copy link
Contributor

@sarvaje sarvaje commented Jun 24, 2020

Fix #3791

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • Added/Updated related documentation.
  • Added/Updated related tests.

Short description of the change(s)

Allow to the icons in manifest to have a combination of values.

@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Jesus David Garcia Gomez seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

1 similar comment
@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Jesus David Garcia Gomez seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@sarvaje sarvaje requested a review from johnemau June 24, 2020 00:38
@sarvaje
Copy link
Contributor Author

sarvaje commented Jun 24, 2020

@webhintio/contributors anyone knows how to update the CLA, I didn't realize the email configured was wrong :s

@molant
Copy link
Member

molant commented Jun 24, 2020

@sa change the author in the commit and reopen the pr?

@sarvaje sarvaje closed this Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web manifest does not support combination of values for icon purpose
3 participants