-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web manifest does not support combination of values for icon purpose #3791
Comments
Looks like we will have to update the manifest, can't remember if we update them automatically on release or if we just copied from schema store, but more reason to do #3413 to automate this. @tmb-github do you know if Firefox supports it as well? |
@molant Sadly, I don't. I just learned about this last week with the most recent version of Chrome Canary. |
@molant It turns out Firefox Preview does support maskable icons...see these articles: |
I'm looking at the commit history of our schema and Looking at the original issue it looks like @amazingcaio disagreed with the resolution and correctly points out that we don't support combinations which seems to be your case ( Maybe there's something we can do with json schema to enable this (and find something similar in TypeScript). I'll update the title and description of the issue. @hxlnt is this something your team might want to get considered? |
@molant I can no longer see my original message (it was apparently clipped when the topic was transferred). FWIW, the article referenced by the Lighthouse audit is: https://web.dev/maskable-icon-audit/ which suggests that users "Set the value of purpose to maskable or any maskable. See Values." And "Values" links to https://developer.mozilla.org/en-US/docs/Web/Manifest/icons#Values, which only lists 3 possible purposes. Are there more purposes than those listed in this spec? |
@tmb-github you can access the original one by pressing on "edited by @molant": The current issue is that you have |
Just a heads-up, when w3c/manifest#833 is merged we'll have to support |
Fix #3791 Close #3841 Co-authored-by: Antón Molleda <[email protected]> Co-authored-by: Caio <[email protected]>
The commit that added support for
maskable
is c5eb40f#diff-07d179b4d8516fb968d006563b37bfe3Unfortunately, as @amazingcaio it does not allow for combinations:
Need to find a way to enable this in the schema and our types.
Note: Original issue text by @tmb-github is available in the history
The text was updated successfully, but these errors were encountered: