[ANALYZER-3004] - Memory Leak when working with analysis report #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changed the point behavior, to not directly attach an event to the canvas when the behavior is "attached" to a pv.Panel. Indirectly, this makes us not leak, in this use case. * Fixed the creation and binding of property chains. In pv.Mark#bind, mark instances' properties were being chained in "strange" ways, causing them to be referenced by properties of `defaults` mark instances (static instances), leaking. This would also cause incorrect and longer property chains...
pamval
added a commit
that referenced
this pull request
Apr 30, 2015
[ANALYZER-3004] - Memory Leak when working with analysis report
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defaultsmark instances (static instances), leaking. This would also cause incorrect and longer property chains...@pamval please review.