[ANALYZER-3004] - Memory Leak when working with analysis report #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Protovis fix. * Fixed tipsy leaking `Tipsy` instances that, would, in turn, leak referenced chart objects. Each re-render caused by clicking the legend would leak one Tipsy instance. The "fakeTipsyTarget" div, created by each tipsy instance, would leak, held by jQuery's cache, due to an attached event, and the element no being removed by jQuery or the event explicitly detached.
pamval
added a commit
that referenced
this pull request
Apr 30, 2015
[ANALYZER-3004] - Memory Leak when working with analysis report
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tipsyinstances that, would, in turn, leak referenced chart objects. Each re-render caused by clicking the legend would leak one Tipsy instance.The "fakeTipsyTarget" div, created by each tipsy instance, would leak, held by jQuery's cache, due to an attached event, and the element no being removed by jQuery or the event explicitly detached.
Depends on webdetails/protovis#22.
@pamval please review.