Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/1.3.0 #3706

Merged
merged 3 commits into from
Sep 15, 2020
Merged

Release/1.3.0 #3706

merged 3 commits into from
Sep 15, 2020

Conversation

GregTheGreek
Copy link
Contributor

@GregTheGreek GregTheGreek commented Sep 2, 2020

Description

This minor release contains an assortment of improvements, and is the first release by @ChainSafeSystems

Changelog

Added

Changed

Fixed

Compare View

v1.2.11 -> v1.3.0

Type of change

  • Release Candidate

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@coveralls
Copy link

coveralls commented Sep 2, 2020

Coverage Status

Coverage decreased (-2.3%) to 78.032% when pulling a88944f on release/1.3.0 into 67aa557 on 1.x.

@spacesailor24
Copy link
Contributor

spacesailor24 commented Sep 2, 2020

Replicating the steps mentioned in previous release for [email protected]

As part of the RC process, am doing some test installations in other projects and running their tests to see if everything.

  • installs properly
  • builds
  • tests pass

(This list will be actively edited)

Project Desc Status
oz-test-helpers Test utils. Subset of their suite is web3 contracts ✔️
synthetix ~1000 units ✔️

UPDATE

Previously oz-test-helpers was failing with the below error, but is no longer doing so - not sure what changed

For oz-test-helpers, after running tests I am receiving:

168 passing (14s)
  1 failing

  1) Contract: expectEvent (web3 contracts) 
       "before each" hook for "accepts emitted events":
     Error: Returned error: Exceeds block gas limit
      at Object.ErrorResponse (node_modules/web3-core-helpers/src/errors.js:29:16)
      at /home/anon/tmp/openzeppelin-test-helpers/node_modules/web3-core-requestmanager/src/index.js:140:36
      at /home/anon/tmp/openzeppelin-test-helpers/node_modules/truffle/build/webpack:/packages/truffle-provider/wrapper.js:112:1
      at XMLHttpRequest.request.onreadystatechange (node_modules/truffle/build/webpack:/~/web3/~/web3-providers-http/src/index.js:96:1)
      at XMLHttpRequestEventTarget.dispatchEvent (node_modules/truffle/build/webpack:/~/xhr2-cookies/dist/xml-http-request-event-target.js:34:1)
      at XMLHttpRequest._setReadyState (node_modules/truffle/build/webpack:/~/xhr2-cookies/dist/xml-http-request.js:208:1)
      at XMLHttpRequest._onHttpResponseEnd (node_modules/truffle/build/webpack:/~/xhr2-cookies/dist/xml-http-request.js:318:1)
      at IncomingMessage.<anonymous> (node_modules/truffle/build/webpack:/~/xhr2-cookies/dist/xml-http-request.js:289:47)
      at endReadableNT (_stream_readable.js:1187:12)
      at processTicksAndRejections (internal/process/task_queues.js:84:21)

@ryanio
Copy link
Collaborator

ryanio commented Sep 4, 2020

I tested the new web3.min.js file with Infura and MetaMask providers and looks good. In MetaMask had success changing accounts and subscribing to new block headers. ✅

spacesailor24
spacesailor24 previously approved these changes Sep 9, 2020
frankiebee
frankiebee previously approved these changes Sep 15, 2020
Copy link
Contributor

@frankiebee frankiebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Thank you!!

@GregTheGreek GregTheGreek dismissed stale reviews from ghost , frankiebee, and spacesailor24 via a88944f September 15, 2020 19:12
@GregTheGreek GregTheGreek merged commit f19481f into 1.x Sep 15, 2020
@GregTheGreek GregTheGreek deleted the release/1.3.0 branch September 15, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants