-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parsing of non-eth_subscription
provider events
#3660
Conversation
…ripton, as other non-subscription events may come down the pipe
eth_subscription
provider events
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog was updated, and after testing changes locally, I no longer receive an error when changing accounts in Metamask
Hi, |
@JF0001 This currently exists on the 1.x branch, it has not yet been published. can you test that version out ? |
Thank you Gregory. Yes, I am no longer seeing the error. The account change in MetaMask is not properly triggering the method, but that is most likely due to my code, which I have been modifying extensively. Could you please add a note to this thread if possible if anything else is modified regarding this fix. |
Description
This PR fixes parsing of non-
eth_subscription
provider events, such as the newwallet_accountsChanged
found in #3659, by adding some additional guards when checking for a subscription callback.Fixes #3659
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.