Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements all methods of the ENS registry #3325

Merged
merged 58 commits into from
Feb 21, 2020
Merged

Implements all methods of the ENS registry #3325

Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
6f89e9d
missing registry methods implemented
nivida Jan 21, 2020
92ce398
copy/paste fail fixed for setOwner
nivida Jan 21, 2020
7ea4937
setter test cases added and setSubnodeOwner fixed in ENS.Registry
nivida Jan 21, 2020
61076b9
consitency increased in eth.ens test
nivida Jan 21, 2020
420afa4
funcDocs added to helper functions for clarification
nivida Jan 21, 2020
ad15a84
consitsency of Registry and ENS method names increased and if require…
nivida Jan 21, 2020
52977a6
Registry section in web3-eth-ens documenation updated
nivida Jan 21, 2020
e92de18
deprecation funcDoc added to ENS.resolver
nivida Jan 21, 2020
a4de580
ENS documentation updated
nivida Jan 21, 2020
56282a2
getTTL and getResolver example corrected in web3-eth-ens.rst
nivida Jan 21, 2020
6ed6ba5
missing Resolver method supportsInterface added, callback signatures …
nivida Jan 22, 2020
08c4fa6
Registry type definition updated in web3-eth-ens module and types imp…
nivida Jan 22, 2020
635245d
old callback signature deprecated with over-loading of the signature …
nivida Jan 22, 2020
a1d58a6
sendOptions defined as optional for all state changing ENS methods an…
nivida Jan 22, 2020
545851a
'sendOptions' renamed to more explicit name 'txConfig' and related do…
nivida Jan 22, 2020
87deb4c
ENS.resolver call changed to call registry.resolver or the deprecatio…
nivida Jan 22, 2020
31522fa
funcDocs in ENS and Registry class of the web3-eth-ens module correct…
nivida Jan 22, 2020
dc6a609
CHANGELOG.md updated
nivida Jan 23, 2020
b9bdb32
Merge branch '1.x' into feature/ENS-registry
nivida Jan 23, 2020
5c88560
in-line comments in ENS.Registry updated
nivida Jan 23, 2020
0e767a7
deprecated resolver and owner method replaced with getResolver and ge…
nivida Jan 28, 2020
aab7c38
separate container for ens e2e tests removed and execution of them ad…
nivida Jan 28, 2020
1a4a53c
Merge branch '1.x' into feature/ENS-registry
nivida Jan 28, 2020
09a3e1a
eth.ens test extended
nivida Jan 29, 2020
dcb5ecc
test cases of eth.ens updated to improve code coverage
nivida Jan 29, 2020
acdaaec
supportsInterface implementation corrected and related test case adde…
nivida Jan 29, 2020
3f4921f
separate e2e ens travis container re-added
nivida Jan 29, 2020
3312ecb
ENS.supportsInterface improved and related documentation added
nivida Jan 29, 2020
bb86ffc
Merge branch '1.x' into feature/ENS-registry
nivida Jan 29, 2020
796c1ce
test cases added in eth.ens, setOwner signature updated, and promises…
nivida Jan 30, 2020
ae5dccc
Merge branch 'feature/ENS-registry' of github.com:ethereum/web3.js in…
nivida Jan 30, 2020
426b782
eth.ens setSubnodeOwner test case description improved
nivida Jan 30, 2020
a85f72d
error handling in ENS and ResolverMethodHandler improved and ENS gett…
nivida Jan 30, 2020
4ba1f14
existing getter test cases extended in eth.ens test file
nivida Jan 30, 2020
0697043
callback branch added for the supportsInterface test
nivida Jan 30, 2020
81b646e
getTTL test cases added to eth.ens
nivida Jan 30, 2020
bca3e7b
eth.ens test extended with 'null' branch for the 'registryAddress' se…
nivida Jan 30, 2020
8d9d3ba
code style immproved in ENS.Registry, checkNetwork test cases re-orde…
nivida Jan 30, 2020
65b1816
Merge branch '1.x' into feature/ENS-registry
nivida Feb 3, 2020
8758098
missing param notation added to funcDoc and test cases updated in eth…
nivida Feb 3, 2020
64e30c8
new registry methods added
nivida Feb 3, 2020
1e90b81
types for the ens module extended
nivida Feb 3, 2020
36f488d
eth-ens documentation extended and consistency improved
nivida Feb 3, 2020
e3e2570
ens types corrected and related dtslint tests updated
nivida Feb 3, 2020
02dfd35
rst external url fixed (RST FTW)
nivida Feb 3, 2020
ccac482
Merge branch '1.x' into feature/ENS-registry
nivida Feb 5, 2020
1373841
new registry methods added to the ENS class
nivida Feb 5, 2020
bc8bf45
eth.ens test cases extended and ithe case added if someone passes an …
nivida Feb 5, 2020
4bcad8b
web3-eth-ens setSubnodeOwner and setSubnodeRecord parameters document…
nivida Feb 5, 2020
ca021fe
'.only' removed in eth.ens test file
nivida Feb 5, 2020
3b58a34
Merge branch '1.x' into feature/ENS-registry
nivida Feb 5, 2020
b6ce933
ENS.js test coverage increased
nivida Feb 5, 2020
e6c611b
func signature of recordExists in web3-eth-ens documentation updated
nivida Feb 5, 2020
0fe461d
funcDoc method notation fixed in Regsitry.js 'ttl' -> 'getTTL'
nivida Feb 5, 2020
2ee1781
wrongly formatted semicolon moved in eth.ens test file
nivida Feb 5, 2020
e61bd66
web3-eth-ens doc typos fixed
nivida Feb 6, 2020
dea023f
Merge branch '1.x' into feature/ENS-registry
nivida Feb 6, 2020
ce19820
Merge branch '1.x' into feature/ENS-registry
nivida Feb 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ Released with 1.0.0-beta.37 code base.
### Added

- ENS module extended with the possibility to add a custom registry (#3301)
- Missing ENS Registry methods and Resolver.supportsInterface method added (#3325)

### Changed

Expand Down
Loading