Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements all methods of the ENS registry #3325

Merged
merged 58 commits into from
Feb 21, 2020
Merged

Implements all methods of the ENS registry #3325

merged 58 commits into from
Feb 21, 2020

Commits on Jan 21, 2020

  1. missing registry methods implemented

    @nivida
    nivida committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    6f89e9d View commit details
    Browse the repository at this point in the history

  2. copy/paste fail fixed for setOwner

    @nivida
    nivida committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    92ce398 View commit details
    Browse the repository at this point in the history

  3. setter test cases added and setSubnodeOwner fixed in ENS.Registry

    @nivida
    nivida committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    7ea4937 View commit details
    Browse the repository at this point in the history

  4. consitency increased in eth.ens test

    @nivida
    nivida committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    61076b9 View commit details
    Browse the repository at this point in the history

  5. funcDocs added to helper functions for clarification

    @nivida
    nivida committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    420afa4 View commit details
    Browse the repository at this point in the history

  6. consitsency of Registry and ENS method names increased and if require… 

    …d methods mmarked as deprecated
    @nivida
    nivida committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    ad15a84 View commit details
    Browse the repository at this point in the history

  7. Registry section in web3-eth-ens documenation updated

    @nivida
    nivida committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    52977a6 View commit details
    Browse the repository at this point in the history

  8. deprecation funcDoc added to ENS.resolver

    @nivida
    nivida committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    e92de18 View commit details
    Browse the repository at this point in the history

  9. ENS documentation updated

    @nivida
    nivida committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    a4de580 View commit details
    Browse the repository at this point in the history

  10. getTTL and getResolver example corrected in web3-eth-ens.rst

    @nivida
    nivida committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    56282a2 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2020

  1. missing Resolver method supportsInterface added, callback signatures … 

    …updated in a backwards compatible way, and related types extended or updated and required deprecation message vor the 'resolver' method added
    @nivida
    nivida committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    6ed6ba5 View commit details
    Browse the repository at this point in the history

  2. Registry type definition updated in web3-eth-ens module and types imp… 

    …roved for state changing methods of the ENS class
    @nivida
    nivida committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    08c4fa6 View commit details
    Browse the repository at this point in the history

  3. old callback signature deprecated with over-loading of the signature … 

    …and adding of the deprecation funcDoc
    @nivida
    nivida committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    635245d View commit details
    Browse the repository at this point in the history

  4. sendOptions defined as optional for all state changing ENS methods an… 

    …d related type tests updated
    @nivida
    nivida committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    a1d58a6 View commit details
    Browse the repository at this point in the history

  5. 'sendOptions' renamed to more explicit name 'txConfig' and related do… 

    …cumentation updated
    @nivida
    nivida committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    545851a View commit details
    Browse the repository at this point in the history

  6. ENS.resolver call changed to call registry.resolver or the deprecatio… 

    …n warning doesn't get printend into the console as expected
    @nivida
    nivida committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    87deb4c View commit details
    Browse the repository at this point in the history

  7. funcDocs in ENS and Registry class of the web3-eth-ens module correct… 

    …ed and improved
    @nivida
    nivida committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    31522fa View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2020

  1. CHANGELOG.md updated

    @nivida
    nivida committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    dc6a609 View commit details
    Browse the repository at this point in the history

  2. Merge branch '1.x' into feature/ENS-registry

    @nivida
    nivida authored Jan 23, 2020
    Configuration menu
    Copy the full SHA
    b9bdb32 View commit details
    Browse the repository at this point in the history

  3. in-line comments in ENS.Registry updated

    @nivida
    nivida committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    5c88560 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2020

  1. deprecated resolver and owner method replaced with getResolver and ge… 

    …tOwner
    @nivida
    nivida committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    0e767a7 View commit details
    Browse the repository at this point in the history

  2. separate container for ens e2e tests removed and execution of them ad… 

    …ded to 'unit_and_e2e_clients'
    @nivida
    nivida committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    aab7c38 View commit details
    Browse the repository at this point in the history

  3. Merge branch '1.x' into feature/ENS-registry

    @nivida
    nivida authored Jan 28, 2020
    Configuration menu
    Copy the full SHA
    1a4a53c View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2020

  1. eth.ens test extended

    @nivida
    nivida committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    09a3e1a View commit details
    Browse the repository at this point in the history

  2. test cases of eth.ens updated to improve code coverage

    @nivida
    nivida committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    dcb5ecc View commit details
    Browse the repository at this point in the history

  3. supportsInterface implementation corrected and related test case adde… 

    …d to eth.ens test
    @nivida
    nivida committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    acdaaec View commit details
    Browse the repository at this point in the history

  4. separate e2e ens travis container re-added

    @nivida
    nivida committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    3f4921f View commit details
    Browse the repository at this point in the history

  5. ENS.supportsInterface improved and related documentation added

    @nivida
    nivida committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    3312ecb View commit details
    Browse the repository at this point in the history

  6. Merge branch '1.x' into feature/ENS-registry

    @nivida
    nivida authored Jan 29, 2020
    Configuration menu
    Copy the full SHA
    bb86ffc View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2020

  1. test cases added in eth.ens, setOwner signature updated, and promises… 

    … flatten
    @nivida
    nivida committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    796c1ce View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/ENS-registry' of github.com:ethereum/web3.js in… 

    …to feature/ENS-registry
    @nivida
    nivida committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    ae5dccc View commit details
    Browse the repository at this point in the history

  3. eth.ens setSubnodeOwner test case description improved

    @nivida
    nivida committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    426b782 View commit details
    Browse the repository at this point in the history

  4. error handling in ENS and ResolverMethodHandler improved and ENS gett… 

    …er test cases extended with the error case
    @nivida
    nivida committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    a85f72d View commit details
    Browse the repository at this point in the history

  5. existing getter test cases extended in eth.ens test file

    @nivida
    nivida committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    4ba1f14 View commit details
    Browse the repository at this point in the history

  6. callback branch added for the supportsInterface test

    @nivida
    nivida committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    0697043 View commit details
    Browse the repository at this point in the history

  7. getTTL test cases added to eth.ens

    @nivida
    nivida committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    81b646e View commit details
    Browse the repository at this point in the history

  8. eth.ens test extended with 'null' branch for the 'registryAddress' se… 

    …tter
    @nivida
    nivida committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    bca3e7b View commit details
    Browse the repository at this point in the history

  9. code style immproved in ENS.Registry, checkNetwork test cases re-orde… 

    …red/moved into a describe block, and error handling reverted and improved in the ResolverMethodHandler
    @nivida
    nivida committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    8d9d3ba View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2020

  1. Merge branch '1.x' into feature/ENS-registry

    @nivida
    nivida authored Feb 3, 2020
    Configuration menu
    Copy the full SHA
    65b1816 View commit details
    Browse the repository at this point in the history

  2. missing param notation added to funcDoc and test cases updated in eth… 

    ….ens.js
    @nivida
    nivida committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    8758098 View commit details
    Browse the repository at this point in the history

  3. new registry methods added

    @nivida
    nivida committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    64e30c8 View commit details
    Browse the repository at this point in the history

  4. types for the ens module extended

    @nivida
    nivida committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    1e90b81 View commit details
    Browse the repository at this point in the history

  5. eth-ens documentation extended and consistency improved

    @nivida
    nivida committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    36f488d View commit details
    Browse the repository at this point in the history

  6. ens types corrected and related dtslint tests updated

    @nivida
    nivida committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    e3e2570 View commit details
    Browse the repository at this point in the history

  7. rst external url fixed (RST FTW)

    @nivida
    nivida committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    02dfd35 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2020

  1. Merge branch '1.x' into feature/ENS-registry

    @nivida
    nivida authored Feb 5, 2020
    Configuration menu
    Copy the full SHA
    ccac482 View commit details
    Browse the repository at this point in the history

  2. new registry methods added to the ENS class

    @nivida
    nivida committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    1373841 View commit details
    Browse the repository at this point in the history

  3. eth.ens test cases extended and ithe case added if someone passes an … 

    …already hashed label
    @nivida
    nivida committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    bc8bf45 View commit details
    Browse the repository at this point in the history

  4. web3-eth-ens setSubnodeOwner and setSubnodeRecord parameters document… 

    …ation updated
    @nivida
    nivida committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    4bcad8b View commit details
    Browse the repository at this point in the history

  5. '.only' removed in eth.ens test file

    @nivida
    nivida committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    ca021fe View commit details
    Browse the repository at this point in the history

  6. Merge branch '1.x' into feature/ENS-registry

    @nivida
    nivida authored Feb 5, 2020
    Configuration menu
    Copy the full SHA
    3b58a34 View commit details
    Browse the repository at this point in the history

  7. ENS.js test coverage increased

    @nivida
    nivida committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    b6ce933 View commit details
    Browse the repository at this point in the history

  8. func signature of recordExists in web3-eth-ens documentation updated

    @nivida
    nivida committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    e6c611b View commit details
    Browse the repository at this point in the history

  9. funcDoc method notation fixed in Regsitry.js 'ttl' -> 'getTTL'

    @nivida
    nivida committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    0fe461d View commit details
    Browse the repository at this point in the history

  10. wrongly formatted semicolon moved in eth.ens test file

    @nivida
    nivida committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    2ee1781 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2020

  1. web3-eth-ens doc typos fixed

    @nivida
    nivida committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    e61bd66 View commit details
    Browse the repository at this point in the history

  2. Merge branch '1.x' into feature/ENS-registry

    @nivida
    nivida authored Feb 6, 2020
    Configuration menu
    Copy the full SHA
    dea023f View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2020

  1. Merge branch '1.x' into feature/ENS-registry

    @nivida
    nivida authored Feb 21, 2020
    Configuration menu
    Copy the full SHA
    ce19820 View commit details
    Browse the repository at this point in the history