Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProviderResolver updated for the latest EIP1193 spec #2347

Merged

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Feb 8, 2019

Description

Fixes #2342

Type of change

  • Enhancement

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on the live network.

@nivida nivida added the Enhancement Includes improvements or optimizations label Feb 8, 2019
@nivida nivida changed the title ProviderResolver updated for la latest EIP1193 spec ProviderResolver updated for the latest EIP1193 spec Feb 8, 2019
@nivida nivida merged commit eba857c into 1.0 Feb 8, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 93.094% when pulling a656f31 on enhancement/update-provider-resolver-to-latest-EIP1193-spec into 71fddd5 on 1.0.

@nivida nivida deleted the enhancement/update-provider-resolver-to-latest-EIP1193-spec branch February 8, 2019 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Includes improvements or optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants