Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ProviderResolver for the new EIP-1193 spec #2342

Closed
nivida opened this issue Feb 7, 2019 · 0 comments
Closed

Update ProviderResolver for the new EIP-1193 spec #2342

nivida opened this issue Feb 7, 2019 · 0 comments
Labels
Enhancement Includes improvements or optimizations

Comments

@nivida
Copy link
Contributor

nivida commented Feb 7, 2019 •
edited
Loading

Expected behavior

A provider implemented with the EIP-1193 standard which does not have the name EthereumProvider will be resolved and handled as EIP-1193 provider.

Actual behavior

Only EIP-1193 providers with the name EthereumProvider will be handled as valid EIP-1193 provider.

Steps to reproduce the behavior

  1. Inject an EIP-1193 provider without the name EthereumProvider

Error Logs

Will throw an invalid provider error.

Versions

Web3.js - v1.0.0-beta.43
@nivida nivida changed the title Update ProviderResolver with new EIP-1193 spec Update ProviderResolver for the new EIP-1193 spec Feb 7, 2019
@nivida nivida mentioned this issue Feb 8, 2019
Merged
12 tasks
@nivida nivida added the Enhancement Includes improvements or optimizations label Feb 8, 2019
@alcuadrado alcuadrado mentioned this issue Sep 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Includes improvements or optimizations
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nivida