Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Replace DeepL Mock Api Server container image #364

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

sbuerk
Copy link
Contributor

@sbuerk sbuerk commented Sep 27, 2024

Note that https://github.com/DeepLcom/deepl-mock needs to create a release for the latest tag
See: DeepLcom/deepl-mock#5

  • [TASK] Switch deeplmockapi server image to ghcr.io/web-vision/wv-deeplmockapi-server
    The used container image for the DeepL Mock API Server has
    been outdated. Instead of creating manual build again this
    has now been properly solved by creating a public repository
    for the container image build along with automatic update
    rebuild and tagging. [1][2]

    This change now uses the new image instead of the stalled one.

    [1] https://github.com/web-vision/wv-deeplmockapi-server
    [2] https://github.com/web-vision/wv-deeplmockapi-server/pkgs/container/wv-deeplmockapi-server

  • [TASK] Remove upper version constraint for deeplcom/deepl-php
    Due to the outdated DeepL Mock Api Server version testing
    the extension with a newer deeplcom/deepl-php client badly
    failed and has been mitigated by adding a composer version
    constraint to avoid breaking dependency versions.

    The container image for the DeepL Mock Api Server has been
    exchanged with a up-to-date once which rebuilds and releases
    itself automatically.

    Used command(s):

    composer require --no-update \
      "deeplcom/deepl-php":"^1.6.0"

@sbuerk sbuerk changed the title deeplmockapiserver 1 [TASK] Replace DeepL Mock Api Server container image and ensure newer version Sep 27, 2024
@sbuerk sbuerk changed the title [TASK] Replace DeepL Mock Api Server container image and ensure newer version [TASK] Replace DeepL Mock Api Server container image Sep 27, 2024
…plmockapi-server`

The used container image for the `DeepL Mock API Server` has
been outdated. Instead of creating manual build again this
has now been properly solved by creating a public repository
for the container image build along with automatic update
rebuild and tagging. [1][2]

This change now uses the new image instead of the stalled one.

[1] https://github.com/web-vision/wv-deeplmockapi-server
[2] https://github.com/web-vision/wv-deeplmockapi-server/pkgs/container/wv-deeplmockapi-server
@sbuerk sbuerk marked this pull request as draft September 27, 2024 15:56
@sbuerk sbuerk marked this pull request as ready for review September 30, 2024 13:05
@sbuerk sbuerk marked this pull request as draft September 30, 2024 13:11
@sbuerk sbuerk marked this pull request as ready for review October 1, 2024 10:14
@sbuerk sbuerk requested a review from NarkNiro October 3, 2024 00:42
@NarkNiro NarkNiro merged commit 3460a8d into main Oct 11, 2024
11 checks passed
@NarkNiro NarkNiro deleted the deeplmockapiserver-1 branch October 11, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants