Cli update #227
Merged
Cli update #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 23, 2016 20:07
marco-c
reviewed
Sep 24, 2016
| @@ -89,6 +89,24 @@ registration.pushManager.subscribe({ | |||
| }); | |||
| ``` | |||
|
|
|||
| ## Command Line | |||
|
|
|||
| You can install `web-push` globally and use it for send notifications and / or | |||
marco-c
reviewed
Sep 24, 2016
| @@ -1,4 +1,3 @@ | |||
| coverage/ | |||
| node_modules/ | |||
| wires | |||
There was a problem hiding this comment.
wires isn't generated by anything in this project.
We used to download and name a file wires for selenium, then selenium looked for 'geckodriver' which we did but saved somewhere else and now we just use the geckodriver module.
There was a problem hiding this comment.
Oh, right. I still have the wires executable in my folder 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements comments from: #213
@marco-c