Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the CLI script #213

Closed
marco-c opened this issue Sep 5, 2016 · 2 comments
Closed

Test the CLI script #213

marco-c opened this issue Sep 5, 2016 · 2 comments
Assignees

Comments

@marco-c
Copy link
Member

marco-c commented Sep 5, 2016

We could write another Selenium test that executes the CLI script instead of calling the web-push functions.

@gauntface
Copy link

I was wondering what you're thoughts would be on the following:

Allowing two actions on the cli:

  1. send-notification
  2. generate-vapid-keys

The formation would be:

web-push <Action> <Action-Options>

This would have usage of either:

web-push send-notification --endpoint=<url> --key=<browser key> [--auth=<auth secret>] [--ttl=<seconds>] [--payload=<message>] [--vapid-audience] [--vapid-subject] [--vapid-pvtkey] [--vapid-pubkey]

web-push generate-vapid-keys [--json]

The output of generate-vapid-keys would be something along the lines of:

$web-push generate-vapid-keys

     ======================================
     Public Key:
     1234567890123456678990

     Private Key:
     12345678901234567890
      ======================================

The idea being if a developer was just starting out, they could get a set of VAPID keys without actually having to run a node script first to then change the script.

@marco-c
Copy link
Member Author

marco-c commented Sep 23, 2016

Sounds good to me, we could also add it to the documentation in the Usage section.

This was referenced Sep 24, 2016
@marco-c marco-c closed this as completed Sep 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants