Test cases where request body gets used before network fallback #27325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
annevk
reviewed
Jan 26, 2021
| @@ -155,6 +155,12 @@ function handleIsHistoryNavigation(event) { | |||
| event.respondWith(new Response(body)); | |||
| } | |||
|
|
|||
| function handleUseAndIgnore(event) { | |||
| const request = event.request; | |||
| request.text(); | |||
There was a problem hiding this comment.
I think we should assert the body value here as well or in a different test. Otherwise it's still unclear whether the server worker can read it.
There was a problem hiding this comment.
It is tested elsewhere: see "FetchEvent#body is a ReadableStream" in fetch-event.https.html.
I added "clone-and-ignore" tests. |
annevk
reviewed
Jan 28, 2021
There was a problem hiding this comment.
Thanks, this looks good from my side modulo that nit. I'd like a service worker peer to also review this, e.g., @wanderview, @jakearchibald, or @asutherland.
service-workers/service-worker/resources/fetch-event-test-worker.js
Outdated
Show resolved
Hide resolved
…er.js Co-authored-by: Anne van Kesteren <[email protected]>
annevk
reviewed
Feb 3, 2021
added 3 commits
February 16, 2021 20:40
…hub.com/web-platform-tests/wpt into yhirano/streaming-upload-sw-passthrough
|
Added tests for whatwg/fetch#572. |
annevk
pushed a commit
to whatwg/fetch
that referenced
this pull request
Feb 18, 2021
Also stop transmitting request's body in this scenario. Service worker PR: w3c/ServiceWorker#1563. Tests: web-platform-tests/wpt#27325. Fixes w3c/ServiceWorker#1560 and fixes #572.
jakearchibald
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for whatwg/fetch#1144.