Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have "Handle Fetch" return error when request's streaming body is unusable #1563

Merged
merged 12 commits into from
Feb 18, 2021
Merged

Have "Handle Fetch" return error when request's streaming body is unusable #1563

merged 12 commits into from
Feb 18, 2021

Conversation

yutakahirano
Copy link
Contributor

@yutakahirano yutakahirano commented Feb 8, 2021 •
edited by pr-preview bot
Loading

@yutakahirano
Copy link
Contributor Author

@annevk @yoichio

This is related to whatwg/fetch#1144.

annevk
annevk reviewed Feb 8, 2021
View reviewed changes
docs/index.bs Outdated Show resolved Hide resolved
docs/index.bs Outdated Show resolved Hide resolved
docs/index.bs Outdated Show resolved Hide resolved
annevk
annevk reviewed Feb 8, 2021
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this mostly looks good and I think I also misunderstood some things initially. Left suggestions for improvements.

docs/index.bs Outdated Show resolved Hide resolved
docs/index.bs Outdated Show resolved Hide resolved
docs/index.bs Outdated Show resolved Hide resolved
docs/index.bs Outdated Show resolved Hide resolved
@annevk annevk mentioned this pull request Feb 9, 2021
Merged
3 tasks
@yutakahirano
Copy link
Contributor Author

Fixed the PR per the discussion at whatwg/fetch#1144.

annevk
annevk reviewed Feb 16, 2021
View reviewed changes
docs/index.bs Outdated Show resolved Hide resolved
@yutakahirano yutakahirano changed the title Have "Handle Fetch" return the request body in addition to response Have "Handle Fetch" return error when request's streaming body is unusable Feb 16, 2021
annevk
annevk approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably also needs review from a service worker maintainer.

@yutakahirano
Copy link
Contributor Author

@jakearchibald , can you take a look? This is part of whatwg/fetch#1144.

MattiasBuelens
MattiasBuelens suggested changes Feb 17, 2021
View reviewed changes
docs/index.bs Outdated Show resolved Hide resolved
@yutakahirano @MattiasBuelens
Update docs/index.bs
40e9e10 
Co-authored-by: Mattias Buelens <[email protected]>
jakearchibald
jakearchibald approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@jakearchibald jakearchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Glad this turned out so simple.

@jakearchibald
Copy link
Contributor

@yutakahirano are you happy for this to be merged?

annevk pushed a commit to whatwg/fetch that referenced this pull request Feb 18, 2021
@yutakahirano
Tee request body on service worker interception
c64f074 
Also stop transmitting request's body in this scenario.

Service worker PR: w3c/ServiceWorker#1563.

Tests: web-platform-tests/wpt#27325.

Fixes w3c/ServiceWorker#1560 and fixes #572.
@yutakahirano
Copy link
Contributor Author

Yeah, thank you!

@jakearchibald jakearchibald merged commit 7777030 into w3c:main Feb 18, 2021
yutakahirano added a commit to web-platform-tests/wpt that referenced this pull request Feb 18, 2021
@yutakahirano @annevk
Test cases where request body gets used before network fallback (#27325)
c30545d 
Tests for whatwg/fetch#1144 and w3c/ServiceWorker#1563.

Co-authored-by: Yutaka Hirano <[email protected]>
Co-authored-by: Anne van Kesteren <[email protected]>
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Feb 24, 2021
@yutakahirano @moz-wptsync-bot
Bug 1688827 [wpt PR 27325] - Test cases where request body gets used …
8bbc366 
…before network fallback, a=testonly

Automatic update from web-platform-tests
Test cases where request body gets used before network fallback (#27325)

Tests for whatwg/fetch#1144 and w3c/ServiceWorker#1563.

Co-authored-by: Yutaka Hirano <[email protected]>
Co-authored-by: Anne van Kesteren <[email protected]>
--

wpt-commits: c30545df6a50c61f3673ed952c78c0a607100d45
wpt-pr: 27325
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Feb 25, 2021
@marco-c
Bug 1688827 [wpt PR 27325] - Test cases where request body gets used …
2d3911f 
…before network fallback, a=testonly

Automatic update from web-platform-tests
Test cases where request body gets used before network fallback (#27325)

Tests for whatwg/fetch#1144 and w3c/ServiceWorker#1563.

Co-authored-by: Yutaka Hirano <yhiranochrmomium.org>
Co-authored-by: Anne van Kesteren <annevkannevk.nl>
--

wpt-commits: c30545df6a50c61f3673ed952c78c0a607100d45
wpt-pr: 27325

UltraBlame original commit: fc2a98935821f5df9bf73b8642ff68ab95e1ea17
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Feb 25, 2021
@marco-c
Bug 1688827 [wpt PR 27325] - Test cases where request body gets used …
bb4cd6f 
…before network fallback, a=testonly

Automatic update from web-platform-tests
Test cases where request body gets used before network fallback (#27325)

Tests for whatwg/fetch#1144 and w3c/ServiceWorker#1563.

Co-authored-by: Yutaka Hirano <yhiranochrmomium.org>
Co-authored-by: Anne van Kesteren <annevkannevk.nl>
--

wpt-commits: c30545df6a50c61f3673ed952c78c0a607100d45
wpt-pr: 27325

UltraBlame original commit: fc2a98935821f5df9bf73b8642ff68ab95e1ea17
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Feb 25, 2021
@marco-c
Bug 1688827 [wpt PR 27325] - Test cases where request body gets used …
17a56f6 
…before network fallback, a=testonly

Automatic update from web-platform-tests
Test cases where request body gets used before network fallback (#27325)

Tests for whatwg/fetch#1144 and w3c/ServiceWorker#1563.

Co-authored-by: Yutaka Hirano <yhiranochrmomium.org>
Co-authored-by: Anne van Kesteren <annevkannevk.nl>
--

wpt-commits: c30545df6a50c61f3673ed952c78c0a607100d45
wpt-pr: 27325

UltraBlame original commit: fc2a98935821f5df9bf73b8642ff68ab95e1ea17
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Mar 5, 2021
@yutakahirano @moz-wptsync-bot
Bug 1688827 [wpt PR 27325] - Test cases where request body gets used …
4d7b0c7 
…before network fallback, a=testonly

Automatic update from web-platform-tests
Test cases where request body gets used before network fallback (#27325)

Tests for whatwg/fetch#1144 and w3c/ServiceWorker#1563.

Co-authored-by: Yutaka Hirano <[email protected]>
Co-authored-by: Anne van Kesteren <[email protected]>
--

wpt-commits: c30545df6a50c61f3673ed952c78c0a607100d45
wpt-pr: 27325
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Mar 8, 2021
@yutakahirano @moz-wptsync-bot
Bug 1688827 [wpt PR 27325] - Test cases where request body gets used …
cc6a2db 
…before network fallback, a=testonly

Automatic update from web-platform-tests
Test cases where request body gets used before network fallback (#27325)

Tests for whatwg/fetch#1144 and w3c/ServiceWorker#1563.

Co-authored-by: Yutaka Hirano <[email protected]>
Co-authored-by: Anne van Kesteren <[email protected]>
--

wpt-commits: c30545df6a50c61f3673ed952c78c0a607100d45
wpt-pr: 27325
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Mar 8, 2021
@yutakahirano @moz-wptsync-bot
Bug 1688827 [wpt PR 27325] - Test cases where request body gets used …
86368bd 
…before network fallback, a=testonly

Automatic update from web-platform-tests
Test cases where request body gets used before network fallback (#27325)

Tests for whatwg/fetch#1144 and w3c/ServiceWorker#1563.

Co-authored-by: Yutaka Hirano <[email protected]>
Co-authored-by: Anne van Kesteren <[email protected]>
--

wpt-commits: c30545df6a50c61f3673ed952c78c0a607100d45
wpt-pr: 27325
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Mar 10, 2021
@marco-c
Bug 1688827 [wpt PR 27325] - Test cases where request body gets used …
e534b28 
…before network fallback, a=testonly

Automatic update from web-platform-tests
Test cases where request body gets used before network fallback (#27325)

Tests for whatwg/fetch#1144 and w3c/ServiceWorker#1563.

Co-authored-by: Yutaka Hirano <yhiranochrmomium.org>
Co-authored-by: Anne van Kesteren <annevkannevk.nl>
--

wpt-commits: c30545df6a50c61f3673ed952c78c0a607100d45
wpt-pr: 27325

UltraBlame original commit: 2472b38eb2f886421d5a062314a87dc33029a393
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Mar 10, 2021
@marco-c
Bug 1688827 [wpt PR 27325] - Test cases where request body gets used …
9260941 
…before network fallback, a=testonly

Automatic update from web-platform-tests
Test cases where request body gets used before network fallback (#27325)

Tests for whatwg/fetch#1144 and w3c/ServiceWorker#1563.

Co-authored-by: Yutaka Hirano <yhiranochrmomium.org>
Co-authored-by: Anne van Kesteren <annevkannevk.nl>
--

wpt-commits: c30545df6a50c61f3673ed952c78c0a607100d45
wpt-pr: 27325

UltraBlame original commit: 02b382fb279e8edb2435787d95fd519f036320b3
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Mar 10, 2021
@marco-c
Bug 1688827 [wpt PR 27325] - Test cases where request body gets used …
8da90b2 
…before network fallback, a=testonly

Automatic update from web-platform-tests
Test cases where request body gets used before network fallback (#27325)

Tests for whatwg/fetch#1144 and w3c/ServiceWorker#1563.

Co-authored-by: Yutaka Hirano <yhiranochrmomium.org>
Co-authored-by: Anne van Kesteren <annevkannevk.nl>
--

wpt-commits: c30545df6a50c61f3673ed952c78c0a607100d45
wpt-pr: 27325

UltraBlame original commit: 2472b38eb2f886421d5a062314a87dc33029a393
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Mar 10, 2021
@marco-c
Bug 1688827 [wpt PR 27325] - Test cases where request body gets used …
1a48e8e 
…before network fallback, a=testonly

Automatic update from web-platform-tests
Test cases where request body gets used before network fallback (#27325)

Tests for whatwg/fetch#1144 and w3c/ServiceWorker#1563.

Co-authored-by: Yutaka Hirano <yhiranochrmomium.org>
Co-authored-by: Anne van Kesteren <annevkannevk.nl>
--

wpt-commits: c30545df6a50c61f3673ed952c78c0a607100d45
wpt-pr: 27325

UltraBlame original commit: 02b382fb279e8edb2435787d95fd519f036320b3
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Mar 10, 2021
@marco-c
Bug 1688827 [wpt PR 27325] - Test cases where request body gets used …
5832103 
…before network fallback, a=testonly

Automatic update from web-platform-tests
Test cases where request body gets used before network fallback (#27325)

Tests for whatwg/fetch#1144 and w3c/ServiceWorker#1563.

Co-authored-by: Yutaka Hirano <yhiranochrmomium.org>
Co-authored-by: Anne van Kesteren <annevkannevk.nl>
--

wpt-commits: c30545df6a50c61f3673ed952c78c0a607100d45
wpt-pr: 27325

UltraBlame original commit: 2472b38eb2f886421d5a062314a87dc33029a393
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Mar 10, 2021
@marco-c
Bug 1688827 [wpt PR 27325] - Test cases where request body gets used …
9e9aa46 
…before network fallback, a=testonly

Automatic update from web-platform-tests
Test cases where request body gets used before network fallback (#27325)

Tests for whatwg/fetch#1144 and w3c/ServiceWorker#1563.

Co-authored-by: Yutaka Hirano <yhiranochrmomium.org>
Co-authored-by: Anne van Kesteren <annevkannevk.nl>
--

wpt-commits: c30545df6a50c61f3673ed952c78c0a607100d45
wpt-pr: 27325

UltraBlame original commit: 02b382fb279e8edb2435787d95fd519f036320b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattiasBuelens MattiasBuelens MattiasBuelens requested changes

@annevk annevk annevk approved these changes

@jakearchibald jakearchibald jakearchibald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yutakahirano @jakearchibald @MattiasBuelens @annevk