Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sensors: Drop tests for Sensor.start()/stop() return types. #25448

Merged
merged 1 commit into from
Sep 10, 2020
Merged

sensors: Drop tests for Sensor.start()/stop() return types. #25448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions generic-sensor/generic-sensor-tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,17 +283,6 @@ function runGenericSensorTests(sensorName,
}, `${sensorName}: Test that sensor can be successfully created and its\
states are correct.`);

sensor_test(async t => {
assert_implements(sensorName in self, `${sensorName} is not supported.`);
const sensor = new sensorType();
const sensorWatcher = new EventWatcher(t, sensor, ["activate", "error"]);
const start_return = sensor.start();

await sensorWatcher.wait_for("activate");
assert_equals(start_return, undefined);
sensor.stop();
}, `${sensorName}: sensor.start() returns undefined.`);

sensor_test(async t => {
assert_implements(sensorName in self, `${sensorName} is not supported.`);
const sensor = new sensorType();
Expand All @@ -307,17 +296,6 @@ function runGenericSensorTests(sensorName,
}, `${sensorName}: no exception is thrown when calling start() on already\
started sensor.`);

sensor_test(async t => {
assert_implements(sensorName in self, `${sensorName} is not supported.`);
const sensor = new sensorType();
const sensorWatcher = new EventWatcher(t, sensor, ["activate", "error"]);
sensor.start();

await sensorWatcher.wait_for("activate");
const stop_return = sensor.stop();
assert_equals(stop_return, undefined);
}, `${sensorName}: sensor.stop() returns undefined.`);

sensor_test(async t => {
assert_implements(sensorName in self, `${sensorName} is not supported.`);
const sensor = new sensorType();
Expand Down