Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sensors: Drop tests for Sensor.start()/stop() return types. #25448

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 9, 2020

These tests were essentially verifying IDL compliance for some methods,
which is not very relevant in this context.

Change-Id: Ib103418bf03b8843eda90ae291dceb224cf9e4a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398918
Commit-Queue: Reilly Grant <[email protected]>
Auto-Submit: Raphael Kubo da Costa <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/heads/master@{#805545}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

These tests were essentially verifying IDL compliance for some methods,
which is not very relevant in this context.

Change-Id: Ib103418bf03b8843eda90ae291dceb224cf9e4a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398918
Commit-Queue: Reilly Grant <[email protected]>
Auto-Submit: Raphael Kubo da Costa <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/heads/master@{#805545}
@stephenmcgruer
Copy link
Contributor

CL just removes tests, flakiness must be pre-existing. Admin-merging.

@stephenmcgruer stephenmcgruer merged commit 66ef447 into master Sep 10, 2020
@stephenmcgruer stephenmcgruer deleted the chromium-export-cl-2398918 branch September 10, 2020 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants