Remove service-workers/stub-* files #18745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This originates in commit 5ac8b78 where specgen.json and the genereated stubs were added. In effect, these stubs don't do anything, and the idea of generating tests from the spec hasn't been realized. Part 1 of web-platform-tests/rfcs#27.
jgraham
approved these changes
Aug 29, 2019
wpt-pr-bot
requested review from
asutherland,
mfalken,
mkruisselbrink and
wanderview
|
Merging as per web-platform-tests/rfcs#27 (comment) and following comment. |
This was referenced Aug 30, 2019
foolip
added a commit
that referenced
this pull request
Sep 9, 2019
The manifest support was added in commit 2650e63, ensuring they aren't treated as tests. All sub-* files were removed in #18745. We still tolerate and drop "stub" items when loading an older manifest version until we bump the version to 7. Part 2 of web-platform-tests/rfcs#27.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Sep 14, 2019
…anifest, a=testonly Automatic update from web-platform-tests Remove support for stub-* files in the manifest (#18746) The manifest support was added in commit 2650e630d310d720b5eb8f94b39960689cec8160, ensuring they aren't treated as tests. All sub-* files were removed in web-platform-tests/wpt#18745. We still tolerate and drop "stub" items when loading an older manifest version until we bump the version to 7. Part 2 of web-platform-tests/rfcs#27. -- wpt-commits: 7e484c2125ef52bd306cba773ca43397a4d8e9e7 wpt-pr: 18746
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Sep 14, 2019
…anifest, a=testonly Automatic update from web-platform-tests Remove support for stub-* files in the manifest (#18746) The manifest support was added in commit 2650e630d310d720b5eb8f94b39960689cec8160, ensuring they aren't treated as tests. All sub-* files were removed in web-platform-tests/wpt#18745. We still tolerate and drop "stub" items when loading an older manifest version until we bump the version to 7. Part 2 of web-platform-tests/rfcs#27. -- wpt-commits: 7e484c2125ef52bd306cba773ca43397a4d8e9e7 wpt-pr: 18746
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…anifest, a=testonly Automatic update from web-platform-tests Remove support for stub-* files in the manifest (#18746) The manifest support was added in commit 2650e630d310d720b5eb8f94b39960689cec8160, ensuring they aren't treated as tests. All sub-* files were removed in web-platform-tests/wpt#18745. We still tolerate and drop "stub" items when loading an older manifest version until we bump the version to 7. Part 2 of web-platform-tests/rfcs#27. -- wpt-commits: 7e484c2125ef52bd306cba773ca43397a4d8e9e7 wpt-pr: 18746 UltraBlame original commit: b3fe57c7e58b3677067506469589a45dd3f7e28e
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…anifest, a=testonly Automatic update from web-platform-tests Remove support for stub-* files in the manifest (#18746) The manifest support was added in commit 2650e630d310d720b5eb8f94b39960689cec8160, ensuring they aren't treated as tests. All sub-* files were removed in web-platform-tests/wpt#18745. We still tolerate and drop "stub" items when loading an older manifest version until we bump the version to 7. Part 2 of web-platform-tests/rfcs#27. -- wpt-commits: 7e484c2125ef52bd306cba773ca43397a4d8e9e7 wpt-pr: 18746 UltraBlame original commit: b3fe57c7e58b3677067506469589a45dd3f7e28e
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
…anifest, a=testonly Automatic update from web-platform-tests Remove support for stub-* files in the manifest (#18746) The manifest support was added in commit 2650e630d310d720b5eb8f94b39960689cec8160, ensuring they aren't treated as tests. All sub-* files were removed in web-platform-tests/wpt#18745. We still tolerate and drop "stub" items when loading an older manifest version until we bump the version to 7. Part 2 of web-platform-tests/rfcs#27. -- wpt-commits: 7e484c2125ef52bd306cba773ca43397a4d8e9e7 wpt-pr: 18746 UltraBlame original commit: b3fe57c7e58b3677067506469589a45dd3f7e28e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This originates in commit 5ac8b78
where specgen.json and the genereated stubs were added.
In effect, these stubs don't do anything, and the idea of generating
tests from the spec hasn't been realized.
Part 1 of web-platform-tests/rfcs#27.