Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for stub-* files in the manifest #18746

Merged
merged 3 commits into from
Sep 9, 2019
Merged

Conversation

foolip
Copy link
Member

@foolip foolip commented Aug 29, 2019

The manifest support was added in commit 2650e63,
ensuring they aren't treated as tests.

Part 2 of web-platform-tests/rfcs#27.

@foolip
Copy link
Member Author

foolip commented Aug 29, 2019

Thanks for the review, @jgraham. When verifying that an incremental update would work I found that it didn't and pushed some changes to deal with that.

Is that fine, or should we bump the manifest version?

@wpt-pr-bot wpt-pr-bot added infra manifest wptrunner The automated test runner, commonly called through ./wpt run labels Aug 29, 2019
@jgraham
Copy link
Contributor

jgraham commented Aug 29, 2019

Oh we don't handle a whole test type being dropped. Hmm, seems a shame to leave that code in until we next bump the manifest version, but maybe not too bad. Add a comment indicating it should be removed when the manifest version is higher than whatever the current version is.

@gsnedders may disagree of course.

Copy link
Member

@gsnedders gsnedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems deliberate that we don't handle test types being removed, though we are pretty inconsistent with validating the JSON conforms to the expected schema.

Can you add a TODO(MANIFESTv7) to the comment so we remember to drop it when we bump the version?

tools/manifest/manifest.py Show resolved Hide resolved
@foolip foolip marked this pull request as ready for review September 6, 2019 14:40
@foolip
Copy link
Member Author

foolip commented Sep 6, 2019

@gsnedders do you want to review again?

@foolip
Copy link
Member Author

foolip commented Sep 9, 2019

@gsnedders merging now, please comment after the fact if you don't like what I did.

@foolip foolip merged commit 7e484c2 into master Sep 9, 2019
@foolip foolip deleted the foolip/stub-tools branch September 9, 2019 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra manifest wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants