Data channel tests updated by Lennart Grahl <[email protected]> #16038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
agouaillard,
alvestrand,
guidou,
henbos,
jan-ivar,
rwaldron and
snuggs
1 task
|
Thanks! Can you post which tests you have removed so I can build a map of tests that still need porting? As promised, I will do that but slowly (all of this is now on a voluntary basis as my studying time is over), and with incremental steps to not end up in the same refactoring mess again. |
You can do a diff of webrtc/RTCDataChannel-id.html from this PR and PR 14424 to get the removed tests. |
alvestrand
requested changes
Mar 23, 2019
youennf
force-pushed
the
webrtc-data-channel-split-1
branch
from
f2c4098 to
d6d0a3e
Compare
lgrahl
reviewed
Mar 23, 2019
youennf
force-pushed
the
webrtc-data-channel-split-1
branch
from
d6d0a3e to
770d194
Compare
alvestrand
approved these changes
Mar 23, 2019
marcoscaceres
pushed a commit
that referenced
this pull request
Jul 23, 2019
…#16038) * Data channel tests modernized/updated by Lennart Grahl <[email protected]> * Fix according Harald comments
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Jan 21, 2020
…ction-ondatachannel.html. r=jgraham It looks like most of the changes from web-platform-tests/wpt#16038 we have already, except some whitespace bits. Differential Revision: https://phabricator.services.mozilla.com/D60469
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jan 21, 2020
…ction-ondatachannel.html. r=jgraham It looks like most of the changes from web-platform-tests/wpt#16038 we have already, except some whitespace bits. Differential Revision: https://phabricator.services.mozilla.com/D60469 --HG-- extra : moz-landing-system : lando
moz-wptsync-bot
added a commit
that referenced
this pull request
Feb 12, 2020
…channel.html. It looks like most of the changes from #16038 we have already, except some whitespace bits. Differential Revision: https://phabricator.services.mozilla.com/D60469 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1610422 gecko-commit: adfbba5ae5f7acc18ae9866badd0e2a242bc2ee1 gecko-integration-branch: central gecko-reviewers: jgraham
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes #14424 commits, squash them and does some update: