Fix according Harald comments

web-platform-tests · Mar 23, 2019 · 770d194 · 770d194
1 parent e31dbc7
commit 770d194
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/webrtc/RTCDataChannel-id.html b/webrtc/RTCDataChannel-id.html
@@ -224,11 +224,10 @@
         to the next step. If no available ID could be generated, or if the value of the
         [[DataChannelId]] slot is being used by an existing RTCDataChannel, throw an
         OperationError exception.
-
-  TODO: Needs updating once https://github.com/w3c/webrtc-pc/pull/1848 has been approved!
  */
 /*
- TODO: Find a way to add back exhausting channel tests.
+ TODO: Improve test coverage for RTCSctpTransport.maxChannels.
+ TODO: Improve test coverage for exhausting channel cases.
  */
 
 /*

diff --git a/webrtc/RTCSctpTransport-constructor.html b/webrtc/RTCSctpTransport-constructor.html
@@ -50,7 +50,7 @@
 
   assert_equals(pc1.sctp, null, 'RTCSctpTransport must be null');
 
-  const offer = await generateDataChannelOffer(pc1);
+  const offer = await generateOffer({ pc: pc1, audio: true });
   await Promise.all([pc1.setLocalDescription(offer), pc2.setRemoteDescription(offer)]);
   const answer = await pc2.createAnswer();
   await pc1.setRemoteDescription(answer);
@@ -66,7 +66,7 @@
 
   assert_equals(pc1.sctp, null, 'RTCSctpTransport must be null');
 
-  const offer = await generateDataChannelOffer(pc2);
+  const offer = await generateOffer({ pc: pc2, audio: true });
   await Promise.all([pc2.setLocalDescription(offer), pc1.setRemoteDescription(offer)]);
   const answer = await pc1.createAnswer();
   await pc1.setLocalDescription(answer);