-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure that Actions.perform is always passed a list #14345
Conversation
You need to move base.py to the right address (tools/wptrunner/wptrunner/executors/base.py) to show only the right changes. |
While this change fixes the test on Chrome and Safari, it breaks the test on Firefox. The reason is Firefox uses a different executor, tools/wptrunner/wptrunner/executors/executormarionette.py, which expects the actions to be specified in the previous format. To fix the test on Chrome without breaking Firefox, I think the right place is in tools/wptrunner/wptrunner/executors/executorwebdriver.py: class WebDriverActionSequenceProtocolPart(ActionSequenceProtocolPart):
...
def send_actions(self, actions):
self.webdriver.actions.perform(actions['actions']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per @JohnChen0 's comment
Thank @JohnChen0 for your comment, I have made the change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have submitted the change, please take a look again, thank you.
@jgraham I fixed the check failure, could you please take a look, thank you? |
Fixes #14343
When calling action_sequence.send_actions, we should pass a list not dictionary, so Actions.perform will get a list.