[ChromeDriver] Make some mouse web platform tests work on wpt serve #14304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 30, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1356123
branch
4 times, most recently
from
3dfbe3b to
1d7309b
Compare
I have changed ExecutePerformActions function in window_commands.cc to execute the actions input sent from Webdriver and convert an element in origin into coordinates. Bug: chromedriver:1897 Change-Id: I407dbad5e001f15ddd4edfd709f5460384e95530 Reviewed-on: https://chromium-review.googlesource.com/c/1356123 Reviewed-by: John Chen <[email protected]> Commit-Queue: Lan Wei <[email protected]> Cr-Commit-Position: refs/heads/master@{#614838}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1356123
branch
from
1d7309b to
fba1e41
Compare
|
This export PR has a merge commit. I've reached out to the author and waiting for resolution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have changed ExecutePerformActions function in window_commands.cc to
execute the actions input sent from Webdriver and convert an element
in origin into coordinates.
Bug: chromedriver:1897
Change-Id: I407dbad5e001f15ddd4edfd709f5460384e95530
Reviewed-on: https://chromium-review.googlesource.com/c/1356123
Reviewed-by: John Chen <[email protected]>
Commit-Queue: Lan Wei <[email protected]>
Cr-Commit-Position: refs/heads/master@{#614838}