Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOM: test listener invocation order #13031

Merged
merged 1 commit into from
Mar 1, 2019
Merged

DOM: test listener invocation order #13031

merged 1 commit into from
Mar 1, 2019

Conversation

annevk
Copy link
Member

@annevk annevk commented Sep 17, 2018

@wpt-pr-bot wpt-pr-bot added the dom label Sep 17, 2018
@annevk annevk mentioned this pull request Sep 17, 2018
Closed
@hayatoito hayatoito self-requested a review September 19, 2018 07:57
@hayatoito
Copy link
Member

LGTM

@foolip foolip mentioned this pull request Dec 20, 2018
Closed
@annevk annevk force-pushed the annevk/dom-listener-order branch from 4ff3821 to d772ebe Compare March 1, 2019 10:37
@annevk annevk merged commit 103df1b into master Mar 1, 2019
@annevk annevk deleted the annevk/dom-listener-order branch March 1, 2019 10:46
annevk added a commit to whatwg/dom that referenced this pull request Mar 1, 2019
@annevk
Fix event path iteration
7aaff50 
Instead of shoehorning all target handling into the bubbling iteration, this separates "capturing" iteration from "bubbling" iteration and the Event object's phase is set to target as appropriate in both.

This also invokes the event listeners in a more natural order.

Tests: web-platform-tests/wpt#13030 & web-platform-tests/wpt#13031.

Fixes #685.
annevk added a commit to whatwg/dom that referenced this pull request Mar 1, 2019
@annevk
Fix event path iteration
9943801 
Instead of shoehorning all target handling into the bubbling iteration, this separates "capturing" iteration from "bubbling" iteration and the Event object's phase is set to target as appropriate in both.

This also invokes the event listeners in a more natural order.

Tests: web-platform-tests/wpt#13030 & web-platform-tests/wpt#13031.

Fixes #685.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hayatoito hayatoito hayatoito approved these changes

@jdm jdm Awaiting requested review from jdm

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees

@hayatoito hayatoito

Labels
dom
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annevk @hayatoito @wpt-pr-bot