DOM: eventPhase during legacy-pre-activation behavior #13030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hayatoito could you review this as well please? |
annevk
added a commit
to whatwg/dom
that referenced
this pull request
Mar 1, 2019
Instead of shoehorning all target handling into the bubbling iteration, this separates "capturing" iteration from "bubbling" iteration and the Event object's phase is set to target as appropriate in both. This also invokes the event listeners in a more natural order. Tests: web-platform-tests/wpt#13030 & web-platform-tests/wpt#13031. Fixes #685.
annevk
force-pushed
the
annevk/legacy-pre-activation-behavior-phase
branch
from
7c18f59
to
6928654
Compare
annevk
added a commit
to whatwg/dom
that referenced
this pull request
Mar 1, 2019
Instead of shoehorning all target handling into the bubbling iteration, this separates "capturing" iteration from "bubbling" iteration and the Event object's phase is set to target as appropriate in both. This also invokes the event listeners in a more natural order. Tests: web-platform-tests/wpt#13030 & web-platform-tests/wpt#13031. Fixes #685.
|
Sorry for the delay. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatwg/dom#686.