Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XHR: overrideMimeType() is not reset by open() #12404

Merged
merged 1 commit into from
Oct 1, 2018

Conversation

annevk
Copy link
Member

@annevk annevk commented Aug 10, 2018

Also fix the number of replacement characters.

See also #12289.

@wpt-pr-bot wpt-pr-bot added the xhr label Aug 10, 2018
annevk added a commit to whatwg/xhr that referenced this pull request Aug 10, 2018
It does not make much sense as overrideMimeType() isn't blocked from being used before open() is invoked. (And 3/4 of the major implementations do not have this behavior.)

Partially reverts 121cee5.

Tests: web-platform-tests/wpt#12404.

Closes web-platform-tests/wpt#12289.
Also fix the number of replacement characters.

See also #12289.
Copy link
Contributor

@wisniewskit wisniewskit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annevk annevk merged commit 25ddc4a into master Oct 1, 2018
@annevk annevk deleted the annevk/overridemimetype-reset branch October 1, 2018 14:45
annevk added a commit to whatwg/xhr that referenced this pull request Oct 1, 2018
It does not make much sense as overrideMimeType() isn't blocked from being used before open() is invoked. (And 3/4 of the major implementations do not have this behavior.)

Partially reverts 121cee5.

Tests: web-platform-tests/wpt#12404.

Closes web-platform-tests/wpt#12289.
Bishwarupjee pushed a commit to Bishwarupjee/xhr that referenced this pull request Jan 31, 2024
It does not make much sense as overrideMimeType() isn't blocked from being used before open() is invoked. (And 3/4 of the major implementations do not have this behavior.)

Partially reverts 86b3705.

Tests: web-platform-tests/wpt#12404.

Closes web-platform-tests/wpt#12289.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants