Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xhr/overridemimetype-unsent-state-force-shiftjis is now at odds with the XHR spec. #12289

Closed
wisniewskit opened this issue Aug 2, 2018 · 5 comments
Labels

Comments

@wisniewskit
Copy link
Contributor

With the recent overrideMimeType changes, the WPT xhr/overridemimetype-unsent-state-force-shiftjis is now invalid (since the mimetype override is cleared as the XHR is opened in step 12).

I'm not sure if this means that the spec is now no longer web-compatible, however.

@foolip foolip added the xhr label Aug 4, 2018
@foolip
Copy link
Member

foolip commented Aug 4, 2018

@annevk

@annevk
Copy link
Member

annevk commented Aug 7, 2018

Sigh, I guess that's why we never cleared overrideMimeType state? Does any implementation follow the specification? I thought at least Edge did.

@foolip
Copy link
Member

foolip commented Aug 7, 2018

https://wpt.fyi/results/xhr/overridemimetype-unsent-state-force-shiftjis.htm?labels=experimental isn't too illuminating, but does suggest some difference between Edge and the others.

@annevk
Copy link
Member

annevk commented Aug 10, 2018

I verified that Edge indeed behaves this way, but in retrospect it seems better to align with the other browsers, especially given the situation on mobile. I'll create some PRs to fix the tests and specification.

annevk added a commit that referenced this issue Aug 10, 2018
Also fix the number of replacement characters.

See also #12289.
annevk added a commit to whatwg/xhr that referenced this issue Aug 10, 2018
It does not make much sense as overrideMimeType() isn't blocked from being used before open() is invoked. (And 3/4 of the major implementations do not have this behavior.)

Partially reverts 121cee5.

Tests: web-platform-tests/wpt#12404.

Closes web-platform-tests/wpt#12289.
@annevk
Copy link
Member

annevk commented Aug 10, 2018

PRs created.

annevk added a commit that referenced this issue Aug 17, 2018
Also fix the number of replacement characters.

See also #12289.
annevk added a commit to whatwg/xhr that referenced this issue Oct 1, 2018
It does not make much sense as overrideMimeType() isn't blocked from being used before open() is invoked. (And 3/4 of the major implementations do not have this behavior.)

Partially reverts 121cee5.

Tests: web-platform-tests/wpt#12404.

Closes web-platform-tests/wpt#12289.
annevk added a commit that referenced this issue Oct 1, 2018
Also fix the number of replacement characters.

See also #12289.
boazsender pushed a commit to bocoup/wpt that referenced this issue Sep 10, 2019
Also fix the number of replacement characters.

See also web-platform-tests#12289.
Bishwarupjee pushed a commit to Bishwarupjee/xhr that referenced this issue Jan 31, 2024
It does not make much sense as overrideMimeType() isn't blocked from being used before open() is invoked. (And 3/4 of the major implementations do not have this behavior.)

Partially reverts 86b3705.

Tests: web-platform-tests/wpt#12404.

Closes web-platform-tests/wpt#12289.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants