Client.postMessage to unloaded Client #10153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client.postMessage to an unloaded Client object must throw an "InvalidStateError" DOMException. (See https://w3c.github.io/ServiceWorker/#dom-client-postmessage.) This adds a test for that requirement. Related spec issue: w3c/ServiceWorker#1042. Related spec PR: w3c/ServiceWorker#1274.
wpt-pr-bot
requested review from
asutherland,
beidson,
mfalken,
mkruisselbrink and
wanderview
Build PASSEDStarted: 2018-03-23 14:56:28 View more information about this build on: |
|
Do we really want this behavior? Typically other |
|
@jungkees Also, how is the implementation capable of synchronously throwing here? The client and its ServiceWorkerContainer may be in another process. |
|
@wanderview, thanks for reviewing. Let's discuss in w3c/ServiceWorker#1291. |
|
Closing this PR without merging as per the decision made in w3c/ServiceWorker#1291: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client.postMessage to an unloaded Client object must throw an
"InvalidStateError" DOMException. (See https://w3c.github.io/ServiceWorker/#dom-client-postmessage.)
This adds a test for that requirement.
Related spec issue: w3c/ServiceWorker#1042.
Related spec PR: w3c/ServiceWorker#1274.