Clarify target object of Client.postMessage can be null #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change addresses the issue described in the second paragraph of #1042 (comment). This change gets |destination| variable initialized to null if the ServiceWorkerContainer object does not exist. Fixes #1042.
docs/index.bs
Outdated
| @@ -1028,7 +1028,7 @@ spec: webappsec-referrer-policy; urlPrefix: https://w3c.github.io/webappsec-refe | |||
| The <dfn method for="Client"><code>postMessage(|message|, |transfer|)</code></dfn> method *must* run these steps: | |||
|
|
|||
| 1. Let |sourceSettings| be the <a>context object</a>'s <a>relevant settings object</a>. | |||
| 1. Let |destination| be the {{ServiceWorkerContainer}} object whose [=ServiceWorkerContainer/service worker client=] is the <a>context object</a>'s [=Client/service worker client=]. | |||
| 1. Let |destination| be the {{ServiceWorkerContainer}} object whose [=ServiceWorkerContainer/service worker client=] is the <a>context object</a>'s [=Client/service worker client=], if any; otherwise let it be null. | |||
There was a problem hiding this comment.
I think ", or null if no match is found" would be clearer.
There was a problem hiding this comment.
That sounds good. I addressed it.
jungkees
added a commit
to jungkees/web-platform-tests
that referenced
this pull request
Mar 23, 2018
Client.postMessage to an unloaded Client object must throw an "InvalidStateError" DOMException. (See https://w3c.github.io/ServiceWorker/#dom-client-postmessage.) This adds a test for that requirement. Related spec issue: w3c/ServiceWorker#1042. Related spec PR: w3c/ServiceWorker#1274.
|
Added a test: web-platform-tests/wpt#10153. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses the issue described in the second paragraph of
#1042 (comment).
This change gets |destination| variable initialized to null if the
ServiceWorkerContainer object does not exist.
Fixes #1042.
Preview | Diff