Skip to content

Commit

Permalink
Add a runtime enabled feature for removal of data: URL in SVGUseElement
Browse files Browse the repository at this point in the history
This CL adds a runtime enabled feature and WPT for removal of data: URLs
in in SVGUseElement.
See: w3c/svgwg#901

But: 1300195
Change-Id: Ieab699fc167b254c65b92ed811756404dcc7c575
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4104249
Reviewed-by: Mike West <[email protected]>
Commit-Queue: Jun Kokatsu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1090945}
  • Loading branch information
shhnjk authored and chromium-wpt-export-bot committed Jan 10, 2023
1 parent dae1cf1 commit fe30ab2
Show file tree
Hide file tree
Showing 5 changed files with 30 additions and 2 deletions.
3 changes: 3 additions & 0 deletions svg/struct/reftests/support/red-rect.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
12 changes: 12 additions & 0 deletions svg/struct/reftests/use-cross-origin.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 7 additions & 0 deletions svg/struct/reftests/use-data-url.tentative.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 6 additions & 0 deletions svg/struct/reftests/use-same-origin.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions svg/struct/scripted/use-load-error-events.tentative.html
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
promise_test(t => {
const svg = document.querySelector('svg');
const use = newUseElement();
const watcher = expectEvents(t, use, ['load']);
const watcher = expectEvents(t, use, ['error']);
const url = getUrl('existing-data');
svg.appendChild(use).setAttribute('href', url);
return watcher;
Expand Down Expand Up @@ -113,7 +113,7 @@
const url = getUrl('existing-data');
svg.appendChild(use).setAttribute('href', url);
t.step_timeout(() => use.setAttribute('href', '#local'));
return makeWatcher(svg, 'load', url);
return makeWatcher(svg, 'error', url);
}, document.title + ', external data: URL reference, existing, changed to local reference while loading');

promise_test(t => {
Expand Down

0 comments on commit fe30ab2

Please sign in to comment.