Skip to content

Commit

Permalink
[table-fragmentation] Remove rowspan avoidance logic.
Browse files Browse the repository at this point in the history
When a cell was rowspanned we'd try to avoid breaking inside it as
this makes the logic circular. This however had the undesired effect
of rowspanned cells which are larger than the current page looking
undesirable, and creating large gaps when printing.

This removes the avoidance logic, at the expense of the rowspanned
cell not having the correct height if the table has grown due to
fragmentation.

Bug: 1396218
Change-Id: I10c0afc7bbc5d3ed3323b33417ee2ee22d191404
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4136462
Reviewed-by: Morten Stenshorne <[email protected]>
Commit-Queue: Ian Kilpatrick <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1090941}
  • Loading branch information
bfgeek authored and chromium-wpt-export-bot committed Jan 10, 2023
1 parent de3c7d7 commit dae1cf1
Showing 1 changed file with 19 additions and 0 deletions.
19 changes: 19 additions & 0 deletions css/css-break/table/table-rowspan-001.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<!DOCTYPE html>
<link rel="help" href="https://bugs.chromium.org/p/chromium/issues/detail?id=1396218">
<link rel="match" href="../../reference/ref-filled-green-100px-square.xht">
<p>Test passes if there is a filled green square and <strong>no red</strong>.</p>
<div style="columns:2; width:100px; gap:0; column-fill:auto; height:100px; background:red;">
<table cellpadding="0" cellspacing="0">
<tr>
<td style="width:25px; height:20px; background:green;"></td>
<td style="width:25px; height:20px; background:green;"></td>
</tr>
<tr>
<td rowspan="2" style="background:green;"></td>
<td style="height:20px; background:green;"></td>
</tr>
<tr>
<td style="height:160px; background:green;"></td>
</tr>
</table>
</div>

0 comments on commit dae1cf1

Please sign in to comment.