-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds display CSS property and common declarations #1967
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
79a2474
Adds display property features
vwallen 89f80c2
Updates element-equivalent declaration descriptions
vwallen 92833f8
Merge branch 'main' into css-display-3
vwallen 53bd2c0
Updates description per review
vwallen 006aa88
Merge branch 'main' into submitted/css-display-3
vwallen 2c56ef2
Adds new key
vwallen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| name: "display: flow-root" | ||
| description: "The `display: flow-root` CSS declaration sets an element as the root element of a new flow layout for its children, preventing margin collapse with sibling elements." | ||
| spec: https://drafts.csswg.org/css-display-3/#inner-model | ||
| caniuse: flow-root | ||
| group: css | ||
| compat_features: | ||
| - css.properties.display.flow-root |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # Generated from: display-flow-root.yml | ||
| # Do not edit this file by hand. Edit the source file instead! | ||
|
|
||
| status: | ||
| baseline: high | ||
| baseline_low_date: 2020-01-15 | ||
| baseline_high_date: 2022-07-15 | ||
| support: | ||
| chrome: "58" | ||
| chrome_android: "58" | ||
| edge: "79" | ||
| firefox: "53" | ||
| firefox_android: "53" | ||
| safari: "13" | ||
| safari_ios: "13" | ||
| compat_features: | ||
| - css.properties.display.flow-root |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| name: "display: list-item" | ||
| description: "The `display: list-item` CSS declaration renders an element with the box layout of a `<li>` HTML element." | ||
| spec: https://drafts.csswg.org/css-display-3/#list-items | ||
| group: | ||
| - css | ||
| - lists | ||
| status: | ||
| compute_from: css.properties.display.list-item | ||
| compat_features: | ||
| - css.properties.display.list-item | ||
| - css.properties.display.list-item.legend-support |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| # Generated from: display-list-item.yml | ||
| # Do not edit this file by hand. Edit the source file instead! | ||
|
|
||
| status: | ||
| baseline: high | ||
| baseline_low_date: 2015-07-29 | ||
| baseline_high_date: 2018-01-29 | ||
| support: | ||
| chrome: "1" | ||
| chrome_android: "18" | ||
| edge: "12" | ||
| firefox: "1" | ||
| firefox_android: "4" | ||
| safari: "1" | ||
| safari_ios: "1" | ||
| compat_features: | ||
| # ⬇️ Same status as overall feature ⬇️ | ||
| # baseline: high | ||
| # baseline_low_date: 2015-07-29 | ||
| # baseline_high_date: 2018-01-29 | ||
| # support: | ||
| # chrome: "1" | ||
| # chrome_android: "18" | ||
| # edge: "12" | ||
| # firefox: "1" | ||
| # firefox_android: "4" | ||
| # safari: "1" | ||
| # safari_ios: "1" | ||
| - css.properties.display.list-item | ||
|
|
||
| # baseline: false | ||
| # support: | ||
| # chrome: "71" | ||
| # chrome_android: "71" | ||
| # edge: "79" | ||
| # firefox: "64" | ||
| # firefox_android: "64" | ||
| - css.properties.display.list-item.legend-support |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| name: "display: ruby" | ||
| description: "The `display: ruby` CSS declaration renders an element with the box layout of a `<ruby>` HTML element. Child elements may use equivalents to `<ruby>` internal elements such as `display: ruby-base` for `<rb>`." | ||
| spec: https://drafts.csswg.org/css-display-3/#layout-specific-display | ||
| group: | ||
| - css | ||
| - ruby | ||
| compat_features: | ||
| - css.properties.display.ruby | ||
| - css.properties.display.ruby-base | ||
| - css.properties.display.ruby-base-container | ||
| - css.properties.display.ruby-text | ||
| - css.properties.display.ruby-text-container | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| # Generated from: display-ruby.yml | ||
| # Do not edit this file by hand. Edit the source file instead! | ||
|
|
||
| status: | ||
| baseline: false | ||
| support: | ||
| firefox: "38" | ||
| firefox_android: "38" | ||
| compat_features: | ||
| # baseline: false | ||
| # support: | ||
| # chrome: "121" | ||
| # chrome_android: "121" | ||
| # firefox: "38" | ||
| # firefox_android: "38" | ||
| - css.properties.display.ruby | ||
| - css.properties.display.ruby-text | ||
|
|
||
| # ⬇️ Same status as overall feature ⬇️ | ||
| # baseline: false | ||
| # support: | ||
| # firefox: "38" | ||
| # firefox_android: "38" | ||
| - css.properties.display.ruby-base | ||
| - css.properties.display.ruby-base-container | ||
| - css.properties.display.ruby-text-container |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| name: "display: table" | ||
| description: "The `display: table` CSS declaration renders an element with the box layout of a `<table>` HTML element. Child elements may use equivalents to `<table>` internal elements such as `display: table-row` for `<tr>`." | ||
| spec: https://drafts.csswg.org/css-display-3/#layout-specific-display | ||
| caniuse: css-table | ||
| group: css | ||
| compat_features: | ||
| - css.properties.display.table | ||
| - css.properties.display.table-caption | ||
| - css.properties.display.table-cell | ||
| - css.properties.display.table-column | ||
| - css.properties.display.table-column-group | ||
| - css.properties.display.table-footer-group | ||
| - css.properties.display.table-header-group | ||
| - css.properties.display.table-row | ||
| - css.properties.display.table-row-group | ||
| - css.properties.display.inline-table |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| # Generated from: display-table.yml | ||
| # Do not edit this file by hand. Edit the source file instead! | ||
|
|
||
| status: | ||
| baseline: high | ||
| baseline_low_date: 2020-07-28 | ||
| baseline_high_date: 2023-01-28 | ||
| support: | ||
| chrome: ≤80 | ||
| chrome_android: "80" | ||
| edge: "80" | ||
| firefox: ≤72 | ||
| firefox_android: "79" | ||
| safari: ≤13.1 | ||
| safari_ios: ≤13.4 | ||
| compat_features: | ||
| # baseline: high | ||
| # baseline_low_date: 2015-07-29 | ||
| # baseline_high_date: 2018-01-29 | ||
| # support: | ||
| # chrome: "1" | ||
| # chrome_android: "18" | ||
| # edge: "12" | ||
| # firefox: "1" | ||
| # firefox_android: "4" | ||
| # safari: "1" | ||
| # safari_ios: "1" | ||
| - css.properties.display.table | ||
| - css.properties.display.table-cell | ||
| - css.properties.display.table-column | ||
| - css.properties.display.table-column-group | ||
| - css.properties.display.table-footer-group | ||
| - css.properties.display.table-header-group | ||
| - css.properties.display.table-row | ||
| - css.properties.display.table-row-group | ||
|
|
||
| # baseline: high | ||
| # baseline_low_date: 2015-07-29 | ||
| # baseline_high_date: 2018-01-29 | ||
| # support: | ||
| # chrome: "1" | ||
| # chrome_android: "18" | ||
| # edge: "12" | ||
| # firefox: "3" | ||
| # firefox_android: "4" | ||
| # safari: "1" | ||
| # safari_ios: "1" | ||
| - css.properties.display.inline-table | ||
|
|
||
| # ⬇️ Same status as overall feature ⬇️ | ||
| # baseline: high | ||
| # baseline_low_date: 2020-07-28 | ||
| # baseline_high_date: 2023-01-28 | ||
| # support: | ||
| # chrome: ≤80 | ||
| # chrome_android: "80" | ||
| # edge: "80" | ||
| # firefox: ≤72 | ||
| # firefox_android: "79" | ||
| # safari: ≤13.1 | ||
| # safari_ios: ≤13.4 | ||
| - css.properties.display.table-caption |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| name: Display | ||
| description: The `display` CSS property sets the display behavior of an element's box within its layout and sets the layout behavior for its child elements. | ||
| spec: https://drafts.csswg.org/css-display-3/#the-display-properties | ||
| group: css | ||
| status: | ||
| compute_from: css.properties.display | ||
| compat_features: | ||
| - css.properties.display | ||
| - css.properties.display.none | ||
ddbeck marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - css.properties.display.none.option_is_hidden | ||
| - css.properties.display.block | ||
| - css.properties.display.inline | ||
| - css.properties.display.inline-block | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| # Generated from: display.yml | ||
| # Do not edit this file by hand. Edit the source file instead! | ||
|
|
||
| status: | ||
| baseline: high | ||
| baseline_low_date: 2015-07-29 | ||
| baseline_high_date: 2018-01-29 | ||
| support: | ||
| chrome: "1" | ||
| chrome_android: "18" | ||
| edge: "12" | ||
| firefox: "1" | ||
| firefox_android: "4" | ||
| safari: "1" | ||
| safari_ios: "1" | ||
| compat_features: | ||
| # ⬇️ Same status as overall feature ⬇️ | ||
| # baseline: high | ||
| # baseline_low_date: 2015-07-29 | ||
| # baseline_high_date: 2018-01-29 | ||
| # support: | ||
| # chrome: "1" | ||
| # chrome_android: "18" | ||
| # edge: "12" | ||
| # firefox: "1" | ||
| # firefox_android: "4" | ||
| # safari: "1" | ||
| # safari_ios: "1" | ||
| - css.properties.display | ||
| - css.properties.display.block | ||
| - css.properties.display.inline | ||
| - css.properties.display.inline-block | ||
| - css.properties.display.none | ||
|
|
||
| # baseline: false | ||
| # support: | ||
| # chrome: "1" | ||
| # chrome_android: "18" | ||
| # edge: "79" | ||
| # firefox: "1" | ||
| # firefox_android: "4" | ||
| - css.properties.display.none.option_is_hidden |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documenting for posterity-
The HTML spec marks
<ruby-base>and<ruby-text-container>as obsolete so I was looking into whether the CSS values should be deprecated (first in the CSS spec, then in BCD).However, there is an open issue to remove them from the list of obselete features. At some point this may see more implementation and need updates, but this is good as is.