Adds display CSS property and common declarations #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
jamesnw
requested changes
Oct 16, 2024
Co-authored-by: James Stuckey Weber <[email protected]>
ddbeck
approved these changes
Oct 21, 2024
jamesnw
reviewed
Oct 21, 2024
| - css.properties.display.ruby-base | ||
| - css.properties.display.ruby-base-container | ||
| - css.properties.display.ruby-text | ||
| - css.properties.display.ruby-text-container |
There was a problem hiding this comment.
Documenting for posterity-
The HTML spec marks <ruby-base> and <ruby-text-container> as obsolete so I was looking into whether the CSS values should be deprecated (first in the CSS spec, then in BCD).
However, there is an open issue to remove them from the list of obselete features. At some point this may see more implementation and need updates, but this is good as is.
jamesnw
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.