Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(mf): set splitChunks.chunks to async by default if using module federation #3104

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

chenjiahan
Copy link
Member

Summary

Set splitChunks.chunks to async by default if using moduleFederation.options.

If using chunks: 'all', the PatchSplitChunksPlugin will turn chunks to a function and it is quite slow when there are thousands of modules.

Related Links

#3067
#3102

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 7a1635a
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/66abad1ebcf0110008b88198
😎 Deploy Preview https://deploy-preview-3104--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 80 (🟢 up 6 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit cc38dec into main Aug 1, 2024
10 checks passed
@chenjiahan chenjiahan deleted the mf_split_chunks_0801 branch August 1, 2024 16:15
@chenjiahan chenjiahan mentioned this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant