Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(mf): only patch split chunks for provider app #3102

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Aug 1, 2024

Summary

The PatchSplitChunksPlugin will slow down the build process because it uses function chunks option, and the function will slow down Rspack when there are thousands of modules.

We can only apply PatchSplitChunksPlugin for the provider app (which uses exposes option) because PatchSplitChunksPlugin is designed to handle remote entries.

Related Links

#3067

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 897a9f0
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/66ab9597c056840008cb15d2
😎 Deploy Preview https://deploy-preview-3102--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 88 (🟢 up 16 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit 87600a7 into main Aug 1, 2024
12 checks passed
@chenjiahan chenjiahan deleted the mf_patch_perf_0801 branch August 1, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant