Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test flake due to expecting exactly one event #67

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Fix test flake due to expecting exactly one event #67

merged 1 commit into from
Apr 25, 2023

Commits on Apr 24, 2023

  1. Fix test flake due to expecting exactly one event 

    The test TestEventsWithReconciling checks that a resource has an event
indicating a successful reconciliation, when reconciliation
succeeds. It can be flakey, though, because it asserts the value of
the whole list of events, and the controller can post multiple events
before it gets checked.

So, instead: check that the list of events _contains_ an event
indicating success.

Signed-off-by: Michael Bridgen <[email protected]>
    @squaremo
    squaremo committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    c325b46 View commit details
    Browse the repository at this point in the history