Fix test flake due to expecting exactly one event #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test TestEventsWithReconciling checks that a resource has an event indicating a successful reconciliation, when reconciliation succeeds. It can be flakey, though, because it asserts the value of the whole list of events, and the controller can post multiple events before it gets checked. So, instead: check that the list of events _contains_ an event indicating success. Signed-off-by: Michael Bridgen <[email protected]>
bigkevmcd
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test TestEventsWithReconciling checks that a resource has an event indicating a successful reconciliation, when reconciliation succeeds. It can be flakey, though, because it asserts the value of the whole list of events, and the controller can post multiple events before it gets checked.
So, instead: check that the list of events contains an event indicating success.