lax FilesystemWriter lifetimes #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows two things: - Calling `FilesystemWriter::write` with Owned and RefMut writer. - push dir/file/etc with lifetimes unrelated to reader from `from_fs_reader` Note: add.rs and replace.rs didn't required any change. I did it to show users that the writer parameter could be consumed by the function.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #361 +/- ##
==========================================
- Coverage 73.07% 72.99% -0.08%
==========================================
Files 21 21
Lines 2908 2907 -1
Branches 2908 2907 -1
==========================================
- Hits 2125 2122 -3
- Misses 515 517 +2
Partials 268 268 ☔ View full report in Codecov by Sentry. |
|
Perfect, thanks. |
wcampbell0x2a
added
the
S-Add-To-Changelog
Closed
wcampbell0x2a
removed
the
S-Add-To-Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows two things:
FilesystemWriter::writewith Owned and RefMut writer.from_fs_readerNote: add.rs and replace.rs didn't required any change. I did it to show users that the writer parameter could be consumed by the function.