Use new deku writer #294

wcampbell0x2a · 2023-10-19T03:12:18Z

No description provided.

github-actions · 2023-10-19T03:30:21Z

Benchmark for `49bff2a`

Click to view benchmark

Test	Base	PR	%
only_read/netgear_ax6100v2	7.0±0.00ms	5.6±0.00ms	-20.00%
only_read/tplink_ax1800	27.7±0.05ms	20.5±0.01ms	-25.99%
write_read/netgear_ax6100v2	1789.7±4.82ms	1795.6±10.18ms	+0.33%
write_read/tplink_ax1800	9.9±0.03s	9.9±0.04s	0.00%

codecov · 2023-10-19T03:45:55Z

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (f206fef) 73.05% compared to head (0eddff9) 73.31%.

❗ Current head 0eddff9 differs from pull request most recent head b877c67. Consider uploading reports for the commit b877c67 to get more accurate results

Files	Patch %	Lines
backhand/src/filesystem/writer.rs	47.36%	5 Missing and 15 partials ⚠️
backhand/src/metadata.rs	50.00%	0 Missing and 8 partials ⚠️
backhand/src/reader.rs	82.92%	5 Missing and 2 partials ⚠️
backhand/src/squashfs.rs	87.50%	1 Missing and 1 partial ⚠️
backhand-cli/src/bin/add.rs	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #294      +/-   ##
==========================================
+ Coverage   73.05%   73.31%   +0.25%     
==========================================
  Files          21       21              
  Lines        2913     2930      +17     
  Branches     2913     2930      +17     
==========================================
+ Hits         2128     2148      +20     
- Misses        519      520       +1     
+ Partials      266      262       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2023-10-19T04:04:59Z

Benchmark for `49bff2a`

Click to view benchmark

Test	Base	PR	%
only_read/netgear_ax6100v2	7.0±0.00ms	5.6±0.01ms	-20.00%
only_read/tplink_ax1800	27.7±0.06ms	20.5±0.07ms	-25.99%
write_read/netgear_ax6100v2	1799.1±5.17ms	1825.8±11.80ms	+1.48%
write_read/tplink_ax1800	10.1±0.08s	10.1±0.05s	0.00%

wcampbell0x2a · 2023-10-19T04:22:18Z

(looks like a leftover println is causing the performance effects)

github-actions · 2023-10-19T12:34:29Z

Benchmark for `7ba92bd`

Click to view benchmark

Test	Base	PR	%
only_read/netgear_ax6100v2	7.0±0.23ms	7.0±0.09ms	0.00%
only_read/tplink_ax1800	25.6±0.52ms	25.6±0.34ms	0.00%
write_read/netgear_ax6100v2	2.3±0.04s	2.3±0.05s	0.00%
write_read/tplink_ax1800	12.5±0.06s	12.5±0.13s	0.00%

github-actions · 2023-10-19T21:39:37Z

Benchmark for `c69bfd4`

Click to view benchmark

Test	Base	PR	%
only_read/netgear_ax6100v2	8.4±0.00ms	6.7±0.00ms	-20.24%
only_read/tplink_ax1800	33.1±0.04ms	24.6±0.09ms	-25.68%
write_read/netgear_ax6100v2	2.2±0.01s	2.2±0.02s	0.00%
write_read/tplink_ax1800	12.1±0.06s	12.1±0.05s	0.00%

github-actions · 2023-11-19T03:34:49Z

Benchmark for `c592038`

Click to view benchmark

Test	Base	PR	%
only_read/netgear_ax6100v2	5.4±0.01ms	5.4±0.01ms	0.00%
only_read/tplink_ax1800	21.7±0.06ms	21.8±0.08ms	+0.46%
write_read/netgear_ax6100v2	1322.9±12.31ms	1295.6±5.36ms	-2.06%
write_read/tplink_ax1800	7.4±0.18s	7.2±0.10s	-2.70%

backhand-cli/src/bin/add.rs

github-actions · 2023-12-18T03:02:59Z

Benchmark for `d7635ec`

Click to view benchmark

Test	Base	PR	%
only_read/netgear_ax6100v2	5.6±0.01ms	5.4±0.00ms	-3.57%
only_read/tplink_ax1800	21.9±0.03ms	21.4±0.02ms	-2.28%
write_read/netgear_ax6100v2	1287.9±4.45ms	1289.0±9.24ms	+0.09%
write_read/tplink_ax1800	7.1±0.01s	7.1±0.01s	0.00%

github-actions · 2023-12-29T00:32:05Z

Benchmark for `1afb005`

Click to view benchmark

Test	Base	PR	%
only_read/netgear_ax6100v2	5.6±0.01ms	5.4±0.00ms	-3.57%
only_read/tplink_ax1800	21.9±0.02ms	21.4±0.01ms	-2.28%
write_read/netgear_ax6100v2	1290.8±4.61ms	1283.1±1.16ms	-0.60%
write_read/tplink_ax1800	7.1±0.04s	7.1±0.02s	0.00%

github-actions · 2024-01-20T01:26:35Z

Benchmark for `f8c6ef0`

Click to view benchmark

Test	Base	PR	%
only_read/netgear_ax6100v2	5.6±0.01ms	5.4±0.01ms	-3.57%
only_read/tplink_ax1800	21.8±0.03ms	21.3±0.01ms	-2.29%
write_read/netgear_ax6100v2	1284.6±2.79ms	1289.1±10.35ms	+0.35%
write_read/tplink_ax1800	7.1±0.01s	7.0±0.01s	-1.41%

github-actions · 2024-01-20T16:43:23Z

Benchmark for `e80451a`

Click to view benchmark

Test	Base	PR	%
only_read/netgear_ax6100v2	5.7±0.00ms	5.1±0.00ms	-10.53%
only_read/tplink_ax1800	21.9±0.06ms	20.7±0.01ms	-5.48%
write_read/netgear_ax6100v2	1284.0±2.52ms	1284.6±3.96ms	+0.05%
write_read/tplink_ax1800	7.0±0.01s	7.0±0.00s	0.00%

github-actions · 2024-01-20T22:34:55Z

Benchmark for `71dd8ce`

Click to view benchmark

Test	Base	PR	%
only_read/netgear_ax6100v2	5.6±0.12ms	5.1±0.00ms	-8.93%
only_read/tplink_ax1800	21.7±0.05ms	20.8±0.35ms	-4.15%
unsquashfs/full	12.6±0.04ms	12.6±0.03ms	0.00%
unsquashfs/full-path-filter	9.3±0.02ms	9.3±0.03ms	0.00%
unsquashfs/list	10.5±0.02ms	10.5±0.20ms	0.00%
unsquashfs/list-path-filter	9.6±0.09ms	9.6±0.02ms	0.00%
write_read/netgear_ax6100v2	1288.8±3.20ms	1283.6±2.55ms	-0.40%
write_read/tplink_ax1800	7.1±0.02s	7.1±0.02s	0.00%

github-actions · 2024-01-21T02:59:37Z

Benchmark for `79378f8`

Click to view benchmark

Test	Base	PR	%
only_read/netgear_ax6100v2	5.6±0.01ms	5.1±0.01ms	-8.93%
only_read/tplink_ax1800	22.3±0.18ms	20.9±0.12ms	-6.28%
unsquashfs/full	13.9±0.38ms	13.3±0.22ms	-4.32%
unsquashfs/full-path-filter	10.5±0.17ms	9.9±0.17ms	-5.71%
unsquashfs/list	11.5±0.19ms	11.0±0.11ms	-4.35%
unsquashfs/list-path-filter	10.5±0.13ms	10.0±0.07ms	-4.76%
write_read/netgear_ax6100v2	1333.1±27.71ms	1326.7±27.72ms	-0.48%
write_read/tplink_ax1800	7.5±0.08s	7.5±0.04s	0.00%

Use new deku writer Updates

github-actions · 2024-02-11T18:10:37Z

Benchmark for `a6563d6`

Click to view benchmark

Test	Base	PR	%
only_read/netgear_ax6100v2	2.8±0.00ms	2.5±0.00ms	-10.71%
only_read/tplink_ax1800	7.2±0.01ms	6.7±0.01ms	-6.94%
unsquashfs/full	10.4±0.23ms	10.5±0.26ms	+0.96%
unsquashfs/full-path-filter	7.1±0.09ms	6.9±0.10ms	-2.82%
unsquashfs/list	8.3±0.16ms	8.1±0.11ms	-2.41%
unsquashfs/list-path-filter	7.4±0.10ms	7.2±0.10ms	-2.70%
write_read/netgear_ax6100v2	1293.8±9.43ms	1288.0±3.40ms	-0.45%
write_read/tplink_ax1800	7.1±0.01s	7.1±0.02s	0.00%

github-actions · 2024-02-11T18:16:07Z

Benchmark for `62733d9`

Click to view benchmark

Test	Base	PR	%
only_read/netgear_ax6100v2	2.8±0.00ms	2.6±0.00ms	-7.14%
only_read/tplink_ax1800	7.2±0.01ms	6.7±0.01ms	-6.94%
unsquashfs/full	10.5±0.14ms	10.1±0.18ms	-3.81%
unsquashfs/full-path-filter	7.0±0.05ms	6.9±0.06ms	-1.43%
unsquashfs/list	8.2±0.06ms	8.0±0.06ms	-2.44%
unsquashfs/list-path-filter	7.3±0.05ms	7.2±0.09ms	-1.37%
write_read/netgear_ax6100v2	1283.8±5.77ms	1278.5±3.00ms	-0.41%
write_read/tplink_ax1800	7.1±0.02s	7.1±0.03s	0.00%

wcampbell0x2a force-pushed the use-deku-writer2 branch from 361900b to adcfa0a Compare October 19, 2023 03:20

wcampbell0x2a mentioned this pull request Oct 19, 2023

Impl writer sharksforarms/deku#355

Merged

wcampbell0x2a force-pushed the use-deku-writer2 branch from adcfa0a to e813bb0 Compare October 19, 2023 12:21

wcampbell0x2a force-pushed the use-deku-writer2 branch from e813bb0 to 9f9cd5f Compare October 19, 2023 21:27

wcampbell0x2a force-pushed the use-deku-writer2 branch from 9f9cd5f to 793b3b7 Compare November 19, 2023 03:27

wcampbell0x2a force-pushed the use-deku-writer2 branch from 793b3b7 to e45c753 Compare December 15, 2023 04:51

wcampbell0x2a changed the base branch from deku-update to master December 15, 2023 04:53

wcampbell0x2a force-pushed the use-deku-writer2 branch from 0de64a0 to 6b9dd70 Compare December 15, 2023 22:26

github-actions bot added A-add backhand-cli: add A-replace backhand-cli: replace A-backhand-lib A-CI GitHub Action A-tests bakchand-tests A-backhand-cli labels Dec 15, 2023

wcampbell0x2a force-pushed the use-deku-writer2 branch 3 times, most recently from b877c67 to c49bec3 Compare December 16, 2023 20:00

wcampbell0x2a commented Dec 16, 2023

View reviewed changes

backhand-cli/src/bin/add.rs Outdated Show resolved Hide resolved

wcampbell0x2a force-pushed the use-deku-writer2 branch from 597e5c4 to 15eeec3 Compare December 17, 2023 01:29

This was referenced Dec 17, 2023

remove the writer reference requirement sharksforarms/deku#384

Merged

remove the writer reference requirement #386

Merged

wcampbell0x2a force-pushed the use-deku-writer2 branch 2 times, most recently from b3370a3 to 9670838 Compare December 18, 2023 01:59

wcampbell0x2a force-pushed the use-deku-writer2 branch 3 times, most recently from cedc675 to 7f28a84 Compare December 18, 2023 02:52

wcampbell0x2a force-pushed the use-deku-writer2 branch 2 times, most recently from d2fb374 to 1dea596 Compare December 29, 2023 00:24

wcampbell0x2a mentioned this pull request Dec 30, 2023

Add API change to CHANGELOG using cargo public-api diff #346

Closed

wcampbell0x2a force-pushed the use-deku-writer2 branch from 1dea596 to 2520b5d Compare January 20, 2024 01:19

wcampbell0x2a force-pushed the use-deku-writer2 branch from 20d0bcc to e6ac161 Compare January 20, 2024 16:31

wcampbell0x2a force-pushed the use-deku-writer2 branch from e6ac161 to a2145b7 Compare January 20, 2024 22:20

wcampbell0x2a force-pushed the use-deku-writer2 branch from a2145b7 to cbea84c Compare January 21, 2024 02:46

wcampbell0x2a force-pushed the use-deku-writer2 branch from cbea84c to ca8f7b1 Compare February 11, 2024 17:54

wcampbell0x2a and others added 4 commits February 11, 2024 13:00

Update deku to use Reader

f608770

Use new deku writer Updates

remove the writer reference requirement

b6dbd98

Reduce reading

15981c3

Update to use deku-perf

c74907a

wcampbell0x2a force-pushed the use-deku-writer2 branch from ca8f7b1 to c74907a Compare February 11, 2024 18:00

Make clippy happy

856ef36

wcampbell0x2a closed this Apr 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use new deku writer #294

Use new deku writer #294

wcampbell0x2a commented Oct 19, 2023 •

edited

Loading

github-actions bot commented Oct 19, 2023

codecov bot commented Oct 19, 2023 •

edited

Loading

github-actions bot commented Oct 19, 2023

wcampbell0x2a commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

github-actions bot commented Nov 19, 2023

github-actions bot commented Dec 18, 2023

github-actions bot commented Dec 29, 2023

github-actions bot commented Jan 20, 2024

github-actions bot commented Jan 20, 2024

github-actions bot commented Jan 20, 2024

github-actions bot commented Jan 21, 2024

github-actions bot commented Feb 11, 2024

github-actions bot commented Feb 11, 2024

Use new deku writer #294

Use new deku writer #294

Conversation

wcampbell0x2a commented Oct 19, 2023 • edited Loading

github-actions bot commented Oct 19, 2023

Benchmark for 49bff2a

codecov bot commented Oct 19, 2023 • edited Loading

Codecov Report

github-actions bot commented Oct 19, 2023

Benchmark for 49bff2a

wcampbell0x2a commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

Benchmark for 7ba92bd

github-actions bot commented Oct 19, 2023

Benchmark for c69bfd4

github-actions bot commented Nov 19, 2023

Benchmark for c592038

github-actions bot commented Dec 18, 2023

Benchmark for d7635ec

github-actions bot commented Dec 29, 2023

Benchmark for 1afb005

github-actions bot commented Jan 20, 2024

Benchmark for f8c6ef0

github-actions bot commented Jan 20, 2024

Benchmark for e80451a

github-actions bot commented Jan 20, 2024

Benchmark for 71dd8ce

github-actions bot commented Jan 21, 2024

Benchmark for 79378f8

github-actions bot commented Feb 11, 2024

Benchmark for a6563d6

github-actions bot commented Feb 11, 2024

Benchmark for 62733d9

wcampbell0x2a commented Oct 19, 2023 •

edited

Loading

Benchmark for `49bff2a`

codecov bot commented Oct 19, 2023 •

edited

Loading

Benchmark for `49bff2a`

Benchmark for `7ba92bd`

Benchmark for `c69bfd4`

Benchmark for `c592038`

Benchmark for `d7635ec`

Benchmark for `1afb005`

Benchmark for `f8c6ef0`

Benchmark for `e80451a`

Benchmark for `71dd8ce`

Benchmark for `79378f8`

Benchmark for `a6563d6`

Benchmark for `62733d9`