Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the overview app #41

Merged
merged 5 commits into from
Apr 27, 2023
Merged

Disable the overview app #41

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4960304
Disable the overview app
AlexRuiz7 Apr 19, 2023
84b6969
Update snapshot
AlexRuiz7 Apr 19, 2023
2d6f9fd
Revert removal of the overview app path
AlexRuiz7 Apr 21, 2023
f663b39
Skip overview page test
yenienserrano Apr 26, 2023
d5a384d
Merge branch '2.4.1' into 37-hide-overview-app
yenienserrano Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plugins/opensearch_dashboards_overview/common/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,5 @@

export const PLUGIN_ID = 'opensearchDashboardsOverview';
export const PLUGIN_NAME = 'Overview';
export const PLUGIN_PATH = `/app/opensearch_dashboards_overview`;
export const PLUGIN_PATH = '';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has to be reverted as it's causing issues with the discover app.

image

AlexRuiz7 marked this conversation as resolved.
Show resolved Hide resolved
export const PLUGIN_ICON = 'inputOutput';
6 changes: 3 additions & 3 deletions ...earch_dashboards_overview/public/components/overview/__snapshots__/overview.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions src/plugins/opensearch_dashboards_overview/public/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,13 @@ export class OpenSearchDashboardsOverviewPlugin
return hasOpenSearchDashboardsApp;
}),
distinct(),
map((hasOpenSearchDashboardsApp) => {
map(() => {
return () => {
if (!hasOpenSearchDashboardsApp) {
return { status: AppStatus.inaccessible, navLinkStatus: AppNavLinkStatus.hidden };
} else {
return { status: AppStatus.accessible, navLinkStatus: AppNavLinkStatus.default };
}
// Wazuh: Hide the OpenSearch Dashboards Overview app
return {
status: AppStatus.inaccessible,
navLinkStatus: AppNavLinkStatus.hidden,
};
};
})
);
Expand Down