Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable the overview app #41

Merged
merged 5 commits into from
Apr 27, 2023
Merged

Disable the overview app #41

merged 5 commits into from
Apr 27, 2023

Conversation

AlexRuiz7
Copy link
Member

@AlexRuiz7 AlexRuiz7 commented Apr 19, 2023 •
edited
Loading

Description

This pull request disables the overview app per Wazuh leaders' request.

Issues Resolved

Closes #37

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@AlexRuiz7 AlexRuiz7 self-assigned this Apr 19, 2023
@AlexRuiz7 AlexRuiz7 linked an issue Apr 19, 2023 that may be closed by this pull request
Hide overview app and its links #37
Closed
AlexRuiz7 added a commit that referenced this pull request Apr 19, 2023
@AlexRuiz7
Revert hiding of the overview app
7fd9605 
Moved to #41
AlexRuiz7 added a commit that referenced this pull request Apr 19, 2023
@AlexRuiz7
Revert hide overview app
edc1d25 
Moved to  #41
yenienserrano
yenienserrano approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Desvelao
Desvelao approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review

🟢 code

@AlexRuiz7 AlexRuiz7 force-pushed the 37-hide-overview-app branch from 913f314 to 84b6969 Compare April 20, 2023 11:48
AlexRuiz7 added a commit that referenced this pull request Apr 20, 2023
@AlexRuiz7
Revert hide overview app
ebc6c7c 
Moved to  #41
@AlexRuiz7 AlexRuiz7 mentioned this pull request Apr 20, 2023
Closed
19 tasks
AlexRuiz7 added a commit that referenced this pull request Apr 20, 2023
@AlexRuiz7
Squashed commit of the following:
329c349 
commit edc1d25
Author: Alex Ruiz Becerra <[email protected]>
Date:   Wed Apr 19 23:50:46 2023 +0200

    Revert hide overview app

    Moved to  #41

commit 80e05b8
Author: Ian Yenien Serrano <[email protected]>
Date:   Tue Apr 18 13:08:13 2023 +0200

    Change the word dashboard to lowercase

commit 80e8e26
Author: Ian Yenien Serrano <[email protected]>
Date:   Tue Apr 18 13:04:35 2023 +0200

    Undo change Wazuh documentation

commit cc6f646
Author: Ian Yenien Serrano <[email protected]>
Date:   Tue Apr 18 12:54:06 2023 +0200

    Undo changes support links

commit eadeaea
Author: Ian Yenien Serrano <[email protected]>
Date:   Tue Apr 18 12:45:52 2023 +0200

    Undo changes to settings.js

commit 7ef51bc
Author: Alex Ruiz Becerra <[email protected]>
Date:   Wed Feb 15 18:37:16 2023 +0100

    Revert changes on useExpandedHeaders setting due to Cypress tests

commit 7baeca3
Author: Alex Ruiz Becerra <[email protected]>
Date:   Fri Feb 10 15:51:32 2023 +0100

    Remove commented code and update snapshots

commit 03b775f
Author: Alex Ruiz Becerra <[email protected]>
Date:   Thu Feb 2 18:47:12 2023 +0100

    Add more changes from Wazuh

commit 75ac4ce
Author: Alex Ruiz Becerra <[email protected]>
Date:   Wed Feb 1 15:20:51 2023 +0100

    Push first batch of changes from Wazuh

commit 3d9ba6d
Author: Alex Ruiz Becerra <[email protected]>
Date:   Mon Apr 17 20:01:21 2023 +0200

    Update Browserslist: caniuse-lite

    Was preventing tests to pass

commit 3c6d5ea
Author: Alex Ruiz Becerra <[email protected]>
Date:   Mon Feb 13 13:48:24 2023 +0100

    Fix functional tests
AlexRuiz7 added a commit that referenced this pull request Apr 20, 2023
@AlexRuiz7
Squashed commit of the following:
d8e7c05 
commit edc1d25
Author: Alex Ruiz Becerra <[email protected]>
Date:   Wed Apr 19 23:50:46 2023 +0200

    Revert hide overview app

    Moved to  #41

commit 80e05b8
Author: Ian Yenien Serrano <[email protected]>
Date:   Tue Apr 18 13:08:13 2023 +0200

    Change the word dashboard to lowercase

commit 80e8e26
Author: Ian Yenien Serrano <[email protected]>
Date:   Tue Apr 18 13:04:35 2023 +0200

    Undo change Wazuh documentation

commit cc6f646
Author: Ian Yenien Serrano <[email protected]>
Date:   Tue Apr 18 12:54:06 2023 +0200

    Undo changes support links

commit eadeaea
Author: Ian Yenien Serrano <[email protected]>
Date:   Tue Apr 18 12:45:52 2023 +0200

    Undo changes to settings.js

commit 7ef51bc
Author: Alex Ruiz Becerra <[email protected]>
Date:   Wed Feb 15 18:37:16 2023 +0100

    Revert changes on useExpandedHeaders setting due to Cypress tests

commit 7baeca3
Author: Alex Ruiz Becerra <[email protected]>
Date:   Fri Feb 10 15:51:32 2023 +0100

    Remove commented code and update snapshots

commit 03b775f
Author: Alex Ruiz Becerra <[email protected]>
Date:   Thu Feb 2 18:47:12 2023 +0100

    Add more changes from Wazuh

commit 75ac4ce
Author: Alex Ruiz Becerra <[email protected]>
Date:   Wed Feb 1 15:20:51 2023 +0100

    Push first batch of changes from Wazuh

commit 3d9ba6d
Author: Alex Ruiz Becerra <[email protected]>
Date:   Mon Apr 17 20:01:21 2023 +0200

    Update Browserslist: caniuse-lite

    Was preventing tests to pass

commit 3c6d5ea
Author: Alex Ruiz Becerra <[email protected]>
Date:   Mon Feb 13 13:48:24 2023 +0100

    Fix functional tests
AlexRuiz7
AlexRuiz7 commented Apr 21, 2023
View reviewed changes
src/plugins/opensearch_dashboards_overview/common/index.ts Outdated
@@ -30,5 +30,5 @@

export const PLUGIN_ID = 'opensearchDashboardsOverview';
export const PLUGIN_NAME = 'Overview';
export const PLUGIN_PATH = `/app/opensearch_dashboards_overview`;
export const PLUGIN_PATH = '';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has to be reverted as it's causing issues with the discover app.

image

yenienserrano added a commit that referenced this pull request Apr 21, 2023
@yenienserrano
Squashed commit of the following:
ea95020 
commit ebc6c7c
Author: Alex Ruiz Becerra <[email protected]>
Date:   Wed Apr 19 23:50:46 2023 +0200

    Revert hide overview app

    Moved to  #41

commit 382d527
Author: Ian Yenien Serrano <[email protected]>
Date:   Tue Apr 18 13:08:13 2023 +0200

    Change the word dashboard to lowercase

commit 0a58c36
Author: Ian Yenien Serrano <[email protected]>
Date:   Tue Apr 18 13:04:35 2023 +0200

    Undo change Wazuh documentation

commit 6224f5b
Author: Ian Yenien Serrano <[email protected]>
Date:   Tue Apr 18 12:54:06 2023 +0200

    Undo changes support links

commit b49aa27
Author: Ian Yenien Serrano <[email protected]>
Date:   Tue Apr 18 12:45:52 2023 +0200

    Undo changes to settings.js

commit 4a972b3
Author: Alex Ruiz Becerra <[email protected]>
Date:   Wed Feb 15 18:37:16 2023 +0100

    Revert changes on useExpandedHeaders setting due to Cypress tests

commit 1e4b14c
Author: Alex Ruiz Becerra <[email protected]>
Date:   Fri Feb 10 15:51:32 2023 +0100

    Remove commented code and update snapshots

commit 99615d4
Author: Alex Ruiz Becerra <[email protected]>
Date:   Thu Feb 2 18:47:12 2023 +0100

    Add more changes from Wazuh

commit bab182d
Author: Alex Ruiz Becerra <[email protected]>
Date:   Wed Feb 1 15:20:51 2023 +0100

    Push first batch of changes from Wazuh
@AlexRuiz7
Revert removal of the overview app path
2d6f9fd 
It was causing the Discover app not to render
@AlexRuiz7 AlexRuiz7 force-pushed the 37-hide-overview-app branch from 2d6e662 to 2d6f9fd Compare April 21, 2023 10:43
@asteriscos asteriscos merged commit 9e1c1ec into 2.4.1 Apr 27, 2023
This was referenced Apr 28, 2023
Merged
Merged
yenienserrano pushed a commit that referenced this pull request May 8, 2023
@AlexRuiz7 @yenienserrano
Squashed commit of the following:
d007cb8 
commit edc1d25
Author: Alex Ruiz Becerra <[email protected]>
Date:   Wed Apr 19 23:50:46 2023 +0200

    Revert hide overview app

    Moved to  #41

commit 80e05b8
Author: Ian Yenien Serrano <[email protected]>
Date:   Tue Apr 18 13:08:13 2023 +0200

    Change the word dashboard to lowercase

commit 80e8e26
Author: Ian Yenien Serrano <[email protected]>
Date:   Tue Apr 18 13:04:35 2023 +0200

    Undo change Wazuh documentation

commit cc6f646
Author: Ian Yenien Serrano <[email protected]>
Date:   Tue Apr 18 12:54:06 2023 +0200

    Undo changes support links

commit eadeaea
Author: Ian Yenien Serrano <[email protected]>
Date:   Tue Apr 18 12:45:52 2023 +0200

    Undo changes to settings.js

commit 7ef51bc
Author: Alex Ruiz Becerra <[email protected]>
Date:   Wed Feb 15 18:37:16 2023 +0100

    Revert changes on useExpandedHeaders setting due to Cypress tests

commit 7baeca3
Author: Alex Ruiz Becerra <[email protected]>
Date:   Fri Feb 10 15:51:32 2023 +0100

    Remove commented code and update snapshots

commit 03b775f
Author: Alex Ruiz Becerra <[email protected]>
Date:   Thu Feb 2 18:47:12 2023 +0100

    Add more changes from Wazuh

commit 75ac4ce
Author: Alex Ruiz Becerra <[email protected]>
Date:   Wed Feb 1 15:20:51 2023 +0100

    Push first batch of changes from Wazuh

commit 3d9ba6d
Author: Alex Ruiz Becerra <[email protected]>
Date:   Mon Apr 17 20:01:21 2023 +0200

    Update Browserslist: caniuse-lite

    Was preventing tests to pass

commit 3c6d5ea
Author: Alex Ruiz Becerra <[email protected]>
Date:   Mon Feb 13 13:48:24 2023 +0100

    Fix functional tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano approved these changes

@Desvelao Desvelao Desvelao approved these changes

@Machi3mfl Machi3mfl Machi3mfl approved these changes

Assignees

@AlexRuiz7 AlexRuiz7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide overview app and its links
5 participants
@AlexRuiz7 @Machi3mfl @Desvelao @yenienserrano @asteriscos