Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch Cypress workflow #35

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Patch Cypress workflow #35

merged 1 commit into from
Apr 20, 2023

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Apr 18, 2023 •
edited by AlexRuiz7
Loading

Description

Check the issue #32 for more details about the apporach followed in this pull request.

This pull request patches the Cypress test to run against the GitHub reference of https://github.com/opensearch-project/opensearch-dashboards-functional-test we want, instead of using github.base_ref.

We have replaced github.base_ref with repository variables.

Issues Resolved

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano linked an issue Apr 18, 2023 that may be closed by this pull request
Skip/fix failing Cypress tests #34
Closed
3 tasks
@AlexRuiz7 AlexRuiz7 changed the title fix cypress test Skip failing Cypress tests Apr 18, 2023
@AlexRuiz7 AlexRuiz7 changed the title Skip failing Cypress tests Patch Cypress workflow Apr 19, 2023
@AlexRuiz7 AlexRuiz7 mentioned this pull request Apr 19, 2023
Merged
8 tasks
@AlexRuiz7 AlexRuiz7 force-pushed the fix-34-cypress-workflow branch from cf7afa7 to f4255aa Compare April 19, 2023 22:48
Desvelao
Desvelao approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review

🟢 code
🟢 automatic tests

@AlexRuiz7 AlexRuiz7 merged commit 5c2f5d9 into 2.4.1 Apr 20, 2023
@AlexRuiz7 AlexRuiz7 mentioned this pull request Apr 20, 2023
Closed
19 tasks
@AlexRuiz7 AlexRuiz7 deleted the fix-34-cypress-workflow branch April 28, 2023 11:58
@AlexRuiz7
Copy link
Member

Re-opened in #49

See #1 (comment) for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skip/fix failing Cypress tests
3 participants
@yenienserrano @AlexRuiz7 @Desvelao