Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove app / component to add sample data #23

Merged
merged 7 commits into from
Apr 28, 2023
Merged

Remove app / component to add sample data #23

merged 7 commits into from
Apr 28, 2023

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Feb 14, 2023 •
edited by AlexRuiz7
Loading

Description

  • Removed all the buttons that redirect to the OpenSearch sample data.
  • Removed the routes to this app / component.
  • Accommodated tests & test snapshots.

Issues Resolved

Screenshots

image
image
image
image

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano self-assigned this Feb 14, 2023
@yenienserrano yenienserrano force-pushed the 19-remove-sample-data branch 2 times, most recently from bb6fb09 to a00df99 Compare February 14, 2023 12:02
@yenienserrano yenienserrano linked an issue Feb 14, 2023 that may be closed by this pull request
Disable the addition of sample data #19
Closed
3 tasks
@yenienserrano
Copy link
Member Author

Build and test / Run functional tests (6) (push) is failing because the add sample data buttons and actions were removed.

@AlexRuiz7 AlexRuiz7 mentioned this pull request Mar 29, 2023
Closed
3 tasks
@AlexRuiz7 AlexRuiz7 force-pushed the 19-remove-sample-data branch 2 times, most recently from 6a7cc3b to 6f42424 Compare April 19, 2023 07:50
@AlexRuiz7 AlexRuiz7 changed the title Remove add sample data and update test, snapshots Remove app / component to add sample data Apr 19, 2023
@AlexRuiz7
Copy link
Member

Depends on #35

@AlexRuiz7 AlexRuiz7 force-pushed the 19-remove-sample-data branch from 6f42424 to f108881 Compare April 20, 2023 11:50
@AlexRuiz7 AlexRuiz7 mentioned this pull request Apr 20, 2023
Closed
19 tasks
@yenienserrano yenienserrano force-pushed the 19-remove-sample-data branch from 3e87f84 to c711f90 Compare April 26, 2023 14:53
@chantal-kelm chantal-kelm self-requested a review April 27, 2023 16:06
chantal-kelm
chantal-kelm approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Captura de pantalla 2023-04-27 a la(s) 13 05 52

Captura de pantalla 2023-04-27 a la(s) 13 05 44

Captura de pantalla 2023-04-27 a la(s) 13 05 38

Machi3mfl
Machi3mfl approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test: ✔️
CR: ✔️

Before

image

image

After

image

@asteriscos asteriscos merged commit 61f6dea into 2.4.1 Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao left review comments

@chantal-kelm chantal-kelm chantal-kelm approved these changes

@Machi3mfl Machi3mfl Machi3mfl approved these changes

Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable the addition of sample data
6 participants
@yenienserrano @AlexRuiz7 @Machi3mfl @Desvelao @chantal-kelm @asteriscos