Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wazuh changes (styles and images) #22

Closed
wants to merge 10 commits into from
Closed

Conversation

AlexRuiz7
Copy link
Member

@AlexRuiz7 AlexRuiz7 commented Feb 14, 2023

Description

The following list of changes have been applied:

  • Changes in CSS.
  • Logos and icons replacements.
  • Replacement of some texts (OpenSearch with Wazuh, for example).
  • Changes in the properties of some fonts.
  • Replace default values for some platform's settings, as applicationTitle and useExpandedHeader.
  • Replace Node options (Unhandled promise error when unable to reach Wazuh API wazuh-dashboard-plugins#3887).
  • Replacement of help links with Wazuh's (titles and URLs).
  • Disabled the Overview plugin.
  • Manage the attempts of installation of the Wazuh plugin (needs further work, but will be done in an individual issue).

List of changes that could not be applied and reason:

  • Replace redirections to /home with /app/wazuh. Reason: the Wazuh plugin is not installed by default, This redirection leads to a 404: app not found view. We need to find a better way to do this change.
    To be done in Replace redirection to /home with /app/wazuh #17 as part of Create default config files for Wazuh #26
  • Changes to the documentation links and replacement of the OSD version with the Wazuh version. Reason: the version field in the package.json file cannot be changed, as it must match the version of the OpenSearch Indexer. A new field must be added to store the Wazuh version, and new code must be created to read this field during and use it during runtime. Will be done in a separate issue.
    Done in Replace documentation links with Wazuh's #18
  • Remove "New to OpenSearch Dashboards" message with link to OpenSearch Dashboards sample data in Dashboard plugin. Reason: this component has several entry points and collateral effects that we need to study. We'll probably need to disable the route to this view and remove all links to it. Some other views might be affected. We'll perform this change in a separate issue.
    Done in Disable the addition of sample data #19

Issues Resolved

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@AlexRuiz7 AlexRuiz7 self-assigned this Feb 14, 2023
@AlexRuiz7 AlexRuiz7 linked an issue Feb 14, 2023 that may be closed by this pull request
@AlexRuiz7
Copy link
Member Author

We had to revert the changes on the useExpandedHeader due to Cypress tests not passing. The Cypress test suite looks for the data-test-subject="homeIcon", which is set in the HomeIcon component depending on the value of the useExpandedHeader for some reason.

const testSubj = customMark ? 'customMark' : useExpandedHeader ? 'homeIcon' : 'defaultMark';

If the tests pass reverting this change, we'll set this setting to false using the configuration file instead of replacing its default value in the code.

@AlexRuiz7 AlexRuiz7 mentioned this pull request Feb 20, 2023
8 tasks
@Desvelao
Copy link
Member

Desvelao commented Apr 14, 2023

@AlexRuiz7
Copy link
Member Author

@AlexRuiz7 AlexRuiz7 changed the title Add Wazuh changes Add Wazuh changes (styles and images) Apr 19, 2023
@@ -164,7 +186,8 @@ export const Template: FunctionComponent<Props> = ({
</div>
);
}
return openSearchLogoSpinner;
// Wazuh: change loading logo
return darkMode ? openSearchLogoSpinnerDark : openSearchLogoSpinner;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is causing an inconsistent and unexpected behavior while using the dark mode. Needs to be checked.

@AlexRuiz7 AlexRuiz7 mentioned this pull request Apr 20, 2023
19 tasks
@AlexRuiz7 AlexRuiz7 closed this Apr 28, 2023
@AlexRuiz7 AlexRuiz7 deleted the 2.4.1-init-wzd branch April 28, 2023 12:12
@AlexRuiz7
Copy link
Member Author

Re-opened in #50

See #1 (comment) for details.

@yenienserrano yenienserrano mentioned this pull request Apr 28, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change CSS styles and images
3 participants