-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Wazuh changes (styles and images) #22
Conversation
We had to revert the changes on the
If the tests pass reverting this change, we'll set this setting to false using the configuration file instead of replacing its default value in the code. |
This change could be missing: https://github.com/wazuh/wazuh-packages/blob/v4.4.1/stack/dashboard/base/builder.sh#L88 |
|
b375911
to
80e05b8
Compare
@@ -164,7 +186,8 @@ export const Template: FunctionComponent<Props> = ({ | |||
</div> | |||
); | |||
} | |||
return openSearchLogoSpinner; | |||
// Wazuh: change loading logo | |||
return darkMode ? openSearchLogoSpinnerDark : openSearchLogoSpinner; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is causing an inconsistent and unexpected behavior while using the dark mode. Needs to be checked.
7fd9605
to
80e05b8
Compare
Moved to #41
edc1d25
to
ebc6c7c
Compare
Re-opened in #50 See #1 (comment) for details. |
Description
The following list of changes have been applied:
applicationTitle
anduseExpandedHeader
.List of changes that could not be applied and reason:
/home
with/app/wazuh
. Reason: the Wazuh plugin is not installed by default, This redirection leads to a 404: app not found view. We need to find a better way to do this change.To be done in Replace redirection to
/home
with/app/wazuh
#17 as part of Create default config files for Wazuh #26version
field in thepackage.json
file cannot be changed, as it must match the version of the OpenSearch Indexer. A new field must be added to store the Wazuh version, and new code must be created to read this field during and use it during runtime. Will be done in a separate issue.Done in Replace documentation links with Wazuh's #18
Done in Disable the addition of sample data #19
Issues Resolved
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr