Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-line validation parameters in config description #4785

Merged

Conversation

asteriscos
Copy link
Member

Description

Team,
this PR adds the wazuh.yml multiline settings validations to the configuration description. The goal is to warn the user about the text area validations to prevent errors.

Issues Resolved

Related issue #4446

image

@asteriscos asteriscos self-assigned this Oct 31, 2022
@asteriscos asteriscos requested a review from a team as a code owner October 31, 2022 13:02
@asteriscos asteriscos changed the title Enhance/add validation params in config description 4446 Add validation parameters in config description Oct 31, 2022
@asteriscos asteriscos changed the title Add validation parameters in config description Add multi-line validation parameters in config description Oct 31, 2022
Copy link
Contributor

@Mayons95 Mayons95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TR: ✔️
Test details

image

@AlexRuiz7 AlexRuiz7 mentioned this pull request Nov 3, 2022
13 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

Code coverage (Jest) % values
Statements 8.31% ( 3044 / 36650 )
Branches 3.9% ( 1102 / 28226 )
Functions 7.29% ( 662 / 9084 )
Lines 8.36% ( 2933 / 35080 )

Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlexRuiz7 AlexRuiz7 merged commit 35b797b into 4.4-7.10 Nov 3, 2022
@AlexRuiz7 AlexRuiz7 deleted the enhance/add-validation-params-in-config-description-4446 branch November 3, 2022 08:07
github-actions bot pushed a commit that referenced this pull request Nov 3, 2022
* Add MultiLine validations to config description

* Reverse tsconfig change

* Add changelog

Co-authored-by: Álex <[email protected]>
(cherry picked from commit 35b797b)
github-actions bot pushed a commit that referenced this pull request Nov 3, 2022
* Add MultiLine validations to config description

* Reverse tsconfig change

* Add changelog

Co-authored-by: Álex <[email protected]>
(cherry picked from commit 35b797b)
AlexRuiz7 pushed a commit that referenced this pull request Nov 3, 2022
…scription (#4796)

Add multi-line validation parameters in config description (#4785)

* Add MultiLine validations to config description

* Reverse tsconfig change

* Add changelog

Co-authored-by: Álex <[email protected]>
(cherry picked from commit 35b797b)

Co-authored-by: Federico Rodriguez <[email protected]>
AlexRuiz7 pushed a commit that referenced this pull request Nov 3, 2022
… description (#4797)

Add multi-line validation parameters in config description (#4785)

* Add MultiLine validations to config description

* Reverse tsconfig change

* Add changelog

Co-authored-by: Álex <[email protected]>
(cherry picked from commit 35b797b)

Co-authored-by: Federico Rodriguez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants