Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vulnerabilities in dependencies #5014

Merged
merged 4 commits into from
Dec 20, 2022
Merged

Fix vulnerabilities in dependencies #5014

merged 4 commits into from
Dec 20, 2022

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Dec 20, 2022 •
edited
Loading

Description

This pull request fixes some problems related to dependency vulnerabilities:

  • Removed angular-chart.js dependency and unused code
  • Upgrade winston to 3.5.1

Issues Resolved

Closes #4956

Evidence

[Provide screenshots or videos to prove this PR solves the issues]

Test

  1. Scenario Plugin logs should be generated without problems
    Given a new environment without plugin logs stored in the filesystem
    When the plugin starts
    Then it should exist the plugin logs files with some logs

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Desvelao Desvelao requested a review from a team as a code owner December 20, 2022 07:40
@Desvelao Desvelao self-assigned this Dec 20, 2022
@Desvelao Desvelao changed the base branch from master to 4.4-7.10 December 20, 2022 07:41
@Desvelao Desvelao added the type/security security issue label Dec 20, 2022
@Desvelao Desvelao linked an issue Dec 20, 2022 that may be closed by this pull request
Update dependencies #4956
Closed
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.69% ( 3212 / 36968 )
Branches 4.43% ( 1271 / 28692 )
Functions 7.59% ( 696 / 9168 )
Lines 8.76% ( 3099 / 35396 )

asteriscos
asteriscos approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

Evidence

Screenshot from 2022-12-20 11-26-48

Screenshot from 2022-12-20 11-26-41

Screenshot from 2022-12-20 11-26-33

Screenshot from 2022-12-20 11-26-22

Screenshot from 2022-12-20 11-25-05

@Desvelao Desvelao merged commit 2e57377 into 4.4-7.10 Dec 20, 2022
@Desvelao Desvelao deleted the fix/4956-dependency-vulnerabilities-kbn-7.10 branch December 20, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteriscos asteriscos asteriscos approved these changes

Assignees

@Desvelao Desvelao

Labels
type/security security issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update dependencies
3 participants
@Desvelao @asteriscos @yenienserrano