Fix build issues on macOS and general build improvements #71
Conversation
This adds a helpful tip for macOS users which suggests to use Homebrew to upgrade the Bash version, as macOS ships with Bash 3 by default.
A dollar sign was incorrectly missing in `Makefile.tools` which prevented the correct execution of the `go` command to extract the `GOPATH`.
This retrocompatible change shifts the default install directory of `kubebuilder` to `/usr/local/opt`, which is by default writable by non-root users on macOS. This preserves the old `$PATH` entry of `kubebuilder` for retrocompatibility.
|
Hi @Robertof. Thanks for your PR. I'm waiting for a pusher member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
@JoelSpeed do these look legit/familiar to you? Looking at the logs it doesn't seem like they're related to the tooling |
|
@Robertof There are (unfortunately) a few tests which flake every now and then, I've set them to rerun, definitely not related to your changes! |
This PR addresses the issues found in #46. In particular:
configurescript depends on bash 4, but gave a particularly bland message. This makes it print a special message formacOSusers suggesting how to upgradebashto version 4 (as by default macOS ships with version 3)golangci-lintinMakefile.toolshad a missing$in a shell evaluation leading to an incorrect path being used for the linting toolkubebuilderis now being installed in/usr/local/optinstead of/usr/localby default as that directory is writable by default on macOS.\o/ Hacktoberfest!