Improve local development #46
Labels
enhancement
New feature or request
good first issue
Good for newcomers
Hacktoberfest
help wanted
Extra attention is needed
Problems
While working on PR #44 I came across some problems with the
Makefile
andconfigure
script.The$() to $ $()
golangci-lint
step does not properly install the linter. It follows the steps here but theMakefile
doesn't properly execute it. It attempts to install to/bin
due to improper syntax hereIt can be fixed by changing the
The
install-kubebuilder-tools
step fails.It tries to install to
/usr/local/
which requires elevated privileges. Following the setup instructions here they use sudo and add/usr/local/kubebuilder/bin
to$PATH
as wellWorkarounds
Working from a Mac I needed to do a few extra steps
The
configure
script is dependent on Bash 4 while Macs come with Bash 3.2 by default https://github.com/pusher/wave/blob/master/configure#L3I was able to upgrade painlessly with
brew update && brew install bash
I manually installed
golangci-lint
withcurl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(go env GOPATH)/bin v1.15.0
(or apply the fix above)I manually installed
kubebuilder
following the steps hereThe text was updated successfully, but these errors were encountered: